@correlucas
Latest solutions
Url Shortener using react and styled-components
#accessibility#axios#react#styled-componentsSubmitted about 3 years agoSCSS, Fetch, theme switcher, responsive mobile first workflow
#fetch#sass/scss#bemSubmitted over 3 years ago
Latest comments
- @jkellerman
One of the best ones i've seen, well done!
- @Rubai-Rahman@jkellerman
Nice solution!
FYI, removing focus outline isn't good for accessibility.
https://pauljadam.com/guides/focus-outlines.html
https://www.a11yproject.com/posts/never-remove-css-outlines/
- @ericpatricio@jkellerman
Really good! Can't fault your solution.
Just a word on accessibility make sure li elements are in ul or ol. 👍
- @salmaane@jkellerman
Hey nice solution 👍
Just some feedback, your products-number element doesn't have a fixed width. When you shrink the viewport the number overflows into the button. You need to change width: 126.6px to min-width: 126.6px.
Also, if you want the text in the button to not go on multiple lines, a little trick is to add 'whitespace: nowrap' to button element.
Hope this helpful.
- @Iamweird2@jkellerman
Very nice! well done.
Just one thing, you may need set a limit on the amount of digits that can be entered or set a fixed height to the output container, if you create a really big number the output container grows and ends up stretching your whole app.
Marked as helpful - @BenConfig@jkellerman
Hey,
The photography section is not in the right place, it's currently sitting underneath the graphic design section which is leaving a big blank space on the right.
Marked as helpful
