Skip to content
OverviewSolutions
6
Comments
5

john

@johnhaab90 points

Hi there! I'm a learning front-end developer, you can find me on Twitter at @johnlhaab.

Latest solutions

Latest comments

  • john•90
    @johnhaab

    Good job on completing this challenge, it looks great!

    As for your issue from looking at the inspect element, your parent div to the img has a total height of 309px, and your img has a total height of around 303. Try and locate the error by researching, removing styles and tweaking the styles.

    I managed to fix your issue by changing "height: 100%" to "height: 98%" inside your ".card-header:hover::before" class.

    Nonetheless great job.

  • john•90
    @johnhaab

    I agree with srayala42 and, Zeyad Mohamed.

    Use google fonts, its amazing also use Font Awesome. Font Awesome is the easy way to get great icons for free and they're SVG! (look up on Youtube to get them setup)

  • john•90
    @johnhaab

    LOOKS FINE ON WEBSITE, LOCALHOST, MY PHONE BUT NOT THIS LOL WHAT

  • john•90
    @johnhaab

    not sure why it looks like that in the preview it looks fine on the website its hosted on?

  • john•90
    @johnhaab

    I removed the <div class="attribution"> in mine as it caused issues.

    And to center the content better you should add min-height:100vh; to the body. And reduce the width value of main_container.

    I am new so take what I say with a grain of salt but it worked well for me on this. <3

    Marked as helpful