P
@Koxone
Latest solutions
Dymanically updating password generator w/ JavaScript
PSubmitted 4 months agoGoing forward, I would like to make even cleaner JS logic. Also, as the codebases grow, practicing annotating with comments to clarify for others becomes increasingly important.
Latest comments
- P@jonatan-samuelsson
You seem to have provided the wrong link, but your browser extension manager seems well-made. Code is clean, well-annotated and functional. A few minor tweaks in functionality could include implementation of the theme switch, which doesn't seem to work atm, real-time updates of the active/inactive views (cards stay on even after toggled to inactive for example), and remembering deletions between tab views (I deleted an ext on the active tab but it was back again when I switched to the All tab).
- @SylvainPS78P@jonatan-samuelsson
Nice work, not much to comment on. Your desktop version is quite wide compared to the design and your font sizes don't change according to screen size, but other than that all good
Marked as helpful - P@Dzik0P@jonatan-samuelsson
Looks really good, nice job!
I'd like to hear your thoughts on hard coding the rating system using JS rather than using custom styled radiobuttons, what made you go for that approach?
- P@taceseptP@jonatan-samuelsson
Well done, good-looking solution, well-structured code.
Your content is rendered quite high up on the page, is that a conscius choice? Asking since it departs from the design.
Also, no matter what quiz topic I choose, I get the HTML quiz. I didn't have to review your code enough to pinpoint the error, but you should look over your jason-fetching and data managment functions.
Marked as helpful - @Bytehax21What are you most proud of, and what would you do differently next time?
Making projects using Figma is way easier and faster than eyeballing the design stuff. I think i made it pretty close to original so no doubts on my work as of now.
What challenges did you encounter, and how did you overcome them?I faced issues with applying CSS on Child elements like p tags as assigning ID to them and then writing CSS didn't work on them so, I did a workaround by assigning the child a class and then using css and the padding was different than mentioned in Figma design file
What specific areas of your project would you like help with?Is my CSS good enough or how can i improve it like in applying padding margins and where to assign class or ID etc.
P@jonatan-samuelssonHey.
Looks good, well done. One thing I noticed is you're using
padding-topto position the card. Another way to do it where it gets centered on the page no matter what is to give your main something like:display: flex; justify-content: center; align-items: center; min-height: 100svh;For your issue with child p-elements, there are multiple solutions. First of all, i'd say that the first paragraph semantically should be a heading (say h2, h3 or such).
If you still wanna keep it as paragraphs, you can either do the id thing like so:
.text #para-1 { ... } .text #para-2 { ... }...or, you could go for child selectors:
.text > p:first-child {...} .text > p:nth-child(2) {...} ... .text > p:last-child {...}Finally, all of this can be nested to make the css more structured:
.text { (some styles for text perhaps) p:nth-child(x) { (some style) } p:nth-child(x) { (some other style) } }Marked as helpful - P@HelewudP@jonatan-samuelsson
I really like your solution, code is super clean and easy to read.
Especially the JS is nicely commented and compartmentalized. I like the idea of using a class like you did, as it makes for better portability and reusability. My solution had a completely different approach, so it's nice to see all the various way to achieve the same functionality.
Marked as helpful
