Skip to content
OverviewSolutions
17
Comments
6
Jose Jimmy
@jose-jimmy

All comments

  • Jose Jimmy•290
    @jose-jimmy

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • The code looks pretty clean and well structured. I would recommend that you update the Readme.md file by using the ReameTemplate.md file to make the repo more engaging.

    Other than that I find your solution pretty amazing keep grinding

    If you have any questions, you can always check out my submission and/or feel free to reach out to me

    I hope you find this helpful 😄 happy coding!

    Marked as helpful
  • Jose Jimmy•290
    @jose-jimmy

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • The code looks pretty clean and well structured, but I would like to add that you might find accessibility issues when you do not place the contents inside <main></main> tag so I would suggest you to wrap all the contents of the <body> tag inside the <main> tag.

    Other than that I find your solution pretty amazing keep grinding

    • If you have any questions or need further clarification, you can always check out my submissions and/or feel free to reach out to me.

    I hope you find this helpful 😄 happy coding!

    Marked as helpful
  • Jose Jimmy•290
    @jose-jimmy

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • For this particular challenge using JSON is not necessary
    • If you want to add more data's and dynamically render the contents then checkout this video it will give a basic understanding of JSON and this video will show you how to use JSON with JavaScript.

    If you have any questions or need further clarification, you can always check out my submissions and/or feel free to reach out to me.

    I hope you find this helpful 😄 happy coding!

  • Jose Jimmy•290
    @jose-jimmy

    Hello there 👋. Congratulations on successfully completing your first challenge! 🎉

    I have some recommendations regarding your code that I believe will be of great interest to you.

    If you wish to keep the font-family in the default way ignore this

    • You can easily select the font-family by clicking on the link provided on the styleguide.md file and going to google fonts then choosing the right font size and importing them as per the css code

    • If this feels overwhelming to you don't worry you can follow any YouTube video this is pretty easy.

    If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

    I hope you find this helpful 😄 happy coding!

    Marked as helpful
  • Jose Jimmy•290
    @jose-jimmy

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    I have some recommendations regarding your code that I believe will be of great interest to you.

    • For getting the white line on top of the creator section what you could do is add the following CSS article .item{border-top: 1px solid hsl(215, 32%, 27%);} to your CSS file.

    • I would strongly recommend that you store the designs, images and codes separately for easily managing the files.

    Other than that I find your solution pretty amazing keep grinding

    -If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

    I hope you find this helpful 😄 happy coding!

    Marked as helpful
  • Jose Jimmy•290
    @jose-jimmy

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • :hover {box-shadow} looks cool, it makes a 3d impression to the whole card section
    • I would have imported the google fonts with the specific font-weights
    • Don't know if this is an issue on my end, when inspecting the solution I got a 404 error message saying download failed (font-family: "Montserrat" style:normal weight:400 stretch:100 src index:0): status=2147746065 source: https://fem-product-preview-card-component-peach.vercel.app/assets/fonts/Montserrat/Montserrat-MEdium.ttf

    ** I hope you find this helpful 😄 Above all, the solution you submitted is great ! **

    Happy coding!

    Marked as helpful