Joy• 30
@JOY2OP
Submitted
I would love to know your thoughts about my CSS file code and whether I'm using best practices.
Po Rith
@jpoechill
All comments
- Po Rith• 320
@jpoechill
Posted
small points:
- desktop visuals seemed fine for me, though I couldn't access the mobile view.
- form validation seemed also fine, although i didn't get to a success page
- per your .css file question, there seems to be line breaks and comments that you might of used for yourself in building. i wouldn't say that what you did was wrong, although the file does come as being not yet completely finished
- per your question about best practices? I can recommend experimenting with tailwind css. its a css framework that may seem intimidating at first, but after short while, should become second nature. tailwind is now popular within industry and mentioned freq. in job postings.
Marked as helpful
1 - Ephraim Phil• 210
@effip24
Submitted
Po Rith• 320@jpoechill
Posted
looks great! the only details I saw were the capitalization of the item statuses, commas in prices, and some strange spacing issues in the 'new invoice' button.
With this, I may also check some things on the mobile view, whereas there seem to be some further spacing issues. All minor issues, overall... ~~
I don't necessarily specialize in React, but the component structure looks good to me!
0 - Andras Kelemen• 160
@androgitai
Submitted
Hello everyone!
This is my solution for the invoice app challenge. I built it full stack and uses Firebase database and authentication. I used React, Redux and CSS modules to build it. It does not use any other dependencies because I wanted to build out the whole app myself.
Let me know what you think ;)
Andro
Po Rith• 320@jpoechill
Posted
Great job!! Can totally feel the amount of work that was put in – much more than I had the energy for. :'D
I completed this project also, and overall it seems like you were able to cover most of the details that gave me a difficult time.
The only thing I would make as worth mentioning is that the extra features/pages can sometimes be distracting to the focus of the project itself. Personally, I really wanted to just dive in and quickly explore the app's functionalities – but overall was a bit bogged down by hesitating whether or not I should actually try to sign up. Even then, I found all the dummy data empty, and had to fill out new invoices myself to get the 'full feeling' of the app.
But again, completely impressed by the amount of work that was put in!!
Marked as helpful
0 - Andrew• 380
@andreich1980
Submitted
Po Rith• 320@jpoechill
Posted
Awesome job! The reordering was tricky for me to figure out. I looked at using some pre-built components before building my own functionality from scratch. [Link to site I used] (https://learnvue.co/2020/01/how-to-add-drag-and-drop-to-your-vuejs-project/#adding-drag-and-drop-functionality)
Also, I really like the readability and formatting of your html, and each of your component separations – something I am much over due for implementing.
Also, fine job with localStorage features – have you checked out state management with Vuex yet?
Cheers!
Marked as helpful
1 - braco• 220
@stevebraco
Submitted
reponsive loading...
Po Rith• 320@jpoechill
Posted
Looks like a great job overall.
Some details I noticed:
- menu toggle on mobile, or small screen widths, seems to be missing
- input container in 'add comment' page stretches beyond screen on mobile
- nav on roadmap page missing
- validation for some commenting and replies missing
- sorting items not accessible by screen reader
Again, great job. The app overall is pretty simple, but it's quite deceiving how many details there are that make it work the way it does. Kudos!
Marked as helpful
1
