Looking to hire developers?
@kevincanderson
What are you most proud of, and what would you do differently next time?
I'm proud of completing my second challenge.
What challenges did you encounter, and how did you overcome them?
It was unclear to me if the box shadow increased when you hovered over the card, so I just when ahead and increased it on hover.
What specific areas of your project would you like help with?
I wasn't sure if the size of the box shadow increased when you hovered over the card.
@kevincanderson
Posted
Great work finishing the project.
Feedback: Mobile view is wider than the screen width of 375, see what you can do there to fit it within that screen size. Take a look at the figma if you can download it.
Laptop, the card should be centered vertiical and horizontally, take a look at flexbox and html height.
And yes, apparently the box shadow does change - missed that in my own project.
overall very nice, keep on coding!
Marked as helpful
What are you most proud of, and what would you do differently next time?
First HTML/CSS project i've done. Next time I will write the HTML first and the move to CSS.
What challenges did you encounter, and how did you overcome them?
I couldn't find a way to center my items, Then I remembers the flexbox approach and min-height: 100vh
What specific areas of your project would you like help with?
Used margins a lot, I wonder if it is the right approach as it doesn't seem all that clean. Also, if I could write the CSS any better and if the HTML is logically correct.
@kevincanderson
Posted
Great work on getting it done.
Try looking into HTML height - something I can across during this one. With VH it always leaves more on there. Not an issue at all, just something I recently learned about.
Code looks good from my perspective, a few repeats of code in CSS, but overall good job.
Something to try: Maybe try getting the attribution outside of the actual project?
Marked as helpful
@Ahrf17
Submitted
@kevincanderson
Posted
Nice work. Without using Figma designs the margins/padding can be tough to replicate. I recommend checking your padding on the QR component as there is less whitespace on yours than the original design. Outside of that, very nice.
@zuolizhu
Submitted
Feedbacks are welcome!
I don't think I did the spacing in a right way.
I used a lot of margins to manage the spacing between header main and footer.
It looks great with certain size(I’m trying to approach the “pixel perfect”). While if the screen size is smaller or larger, the spacing of those pieces are not good.
Any suggestion of managing spacing are appreciate!
Thanks!
@kevincanderson
Posted
Looks good. Some spacing towards top missing compared to design, minor fix; but overall very nice work
