Looking to hire developers?
@kfairris
@carlosloureda
Submitted
Any suggestion will be welcome. If you have suggestions on how to improve the BEM naming that would be great and also if you would create the share div in another different way to be shown in desktop/mobile views also great.
Thanks in advanced
@kfairris
Posted
Looks good Carlos. I've been playing around with BEM as well and I love being able to use it with SCSS. It allows you to nest classes and not have to type things over and over again. [Check this article.] (https://medium.com/@andrew_barnes/bem-and-sass-a-perfect-match-5e48d9bc3894)
Of course you have to compile the SCSS, but I use VS Code with a ["Live SASS Compiler" extension] (https://marketplace.visualstudio.com/items?itemName=ritwickdey.live-sass).
Enjoy!
@eboriley
Submitted
@kfairris
Posted
You've set the 'height' on a number of items and that causes the images to distort and look squished.
I forked your repo and made some changes to your 'huddle-landing' section. Check out the updates I made to your code.
@Ctaracena
Submitted
Hi folks, finally finished this challenge, javascript it scares me a lot, please be free to comment, thanks.
@kfairris
Posted
Nice work Carlos. I forked your repo to play around with it and I added some CSS transitions to your switch class, to animate the toggle switch. I would also make the entire slider trigger the toggle and not just the button. So I changed the btn.addEventListener to slider.addEventListener and that did the trick.
I'm not a JS expert, but there seems to be a lot of duplicate items in there that could be combined. How would you accomplish that?
@emestabillo
Submitted
This was a true test in writing responsive code. Would appreciate your thoughts. Many thanks to my mentor @shahsilo for helping me get really close to the design!
@kfairris
Posted
Wow that’s identical. Great job!
