Skip to content
OverviewSolutions
6
Comments
4
P
Karen L Byrd
@klb-dev

All comments

  • P
    Karen L Byrd•60
    @klb-dev

    Looks amazing very similar to the original design.

  • P
    Karen L Byrd•60
    @klb-dev

    I love that you added your picture and location. The code looks sleek and works well.

  • P
    Karen L Byrd•60
    @klb-dev

    Great job on the design and coding so far. Your efforts are evident and appreciated. The code is clean, but why not use <button> or <a> for the learning button? You placed it in <p>. The heading should be an <h1> as well. These tags are done for screen readers and people with visibility issues. Your avatar image does not show up even though it looks correct. Placing a '.' before the first '/' would make it work.

    CSS looks good; maybe start with mobile first and then have fewer media queries to produce more DRY code—great job with styling.

  • P
    Karen L Byrd•60
    @klb-dev

    NA