arash• 280
@deadazix
Submitted
this was one of my hardest project I have ever done and still edit button does not work I did use React for this project and had lots of fun using react!
Kofi Nartey
@kofinartey
All comments
- Kofi Nartey• 650
@kofinartey
Posted
Hey Arash, currently, your edit functionality doesn't seem to work, so you could look at that. I tried to look at you code on but it seems you didn't put in the right link to the repository so I can't offer any specific contribution as at now.
But on the CommentsSection div, setting a width of 90% and 60% for mobile and desktop screen sizes respectively should make them a lot more centered.
I'd also suggest maintaining the paragraph(<p>) font-size of 16px for desktop sizes.
Beyond that, you have a decent application. Keep it up.
Marked as helpful
1 @hikmatullah-mohammadi
Submitted
Hello, It took me about 25 hours to build it. Looking forward to any feedbacks, especially on the way I structure my code, and the amount of time it took me to solve the challenge.
#nothing_is_hard_coded_here
Thank you! a special thanks to #frontendmentor.io team.
Kofi Nartey• 650@kofinartey
Posted
Awesome job mate. Here a few changes I figured you could implement. *You seem to have forgotten to set the font to what was specified in the design guide: a simple css import could fix that.
*On mobile, the nav items do not get hidden and neither do you render the hamburger menu.
*And it also seems the carousel is stuck to just one form as opposed to the different versions for mobile and desktop.
Great work all the same. Keep pushing💪
Marked as helpful
1- Jonathan Martínez• 3,275
@Jommartinez
Submitted
Kofi Nartey• 650@kofinartey
Posted
Great stuff mate. Love the button:active animations you have here.
Just a lil something; the hover state on the button in the "simplify how your team works" section seems broken.
I currently working on this project and was stuck on something. Unfortunately the link to your code doesn't seem to work.
0 - Fraser Watt• 1,790
@fraserwat
Submitted
-
This was the first time I'd used CSS Grid (and I think it shows!). I'm sure there must be a more elegant way of positioning my card items than doing different grid row/col configurations in a bunch of media queries in SCSS. Any feedback on this v much appreciated.
-
Issue with footer - setting
position: absolute; bottom:0;positions it correctly in desktop but when the width of the page gets narrow enough to push the boxes down, my footer seems to break and it becomes a floating element. However, when footer set toposition: relative; bottom: 0;, it fixes the issue of floating over the CSS grid, but on desktop its too high up (close to the feature cards, which I've kept as is the "least broken" result). Any ideas on this?
Aside from those two (quite minor) issues I'm quite proud of this one! 😊
Kofi Nartey• 650@kofinartey
Posted
Hey, great stuff you have here. Not that it really is a problem, but the content get squished when you go beyond 300px . I suggest you consider adding a min-width of 375px, that way you can't squeeze the site beyond that.
Great work however.
0 -
- Omar Ahmed• 200
@OmarIsmail277
Submitted
Any Suggestions or Recommendations? Thank you in advance.
Kofi Nartey• 650@kofinartey
Posted
Great stuff mate. I love you workflow. Unfortunately you repeated Daniel's picture for Jeanette
0 - Oliver Sagala• 120
@sagspot
Submitted
I had trouble with the slider. I feel what I did was hackish, but it still brings trouble on browser resize. Any help will be appreciated.
I would also love to know how you achieved the backgrounds
Kofi Nartey• 650@kofinartey
Posted
Wow man. I love your work. Unfortunately I'm not so adept at JS and SASS to know what's going on here. But I must say that it is pretty impressive. Good job
1 - Kofi Nartey• 650
@kofinartey
Submitted
Hi everyone. This is my first published project since I begun learning to code. I'd appreciate it if anyone goes through my solution and suggest areas I could improve upon. Super happy to learn from y'all.
Kofi Nartey• 650@kofinartey
Posted
Oh wow. I just laid out my process before starting. The intent was to delete them before I posted, but I forgot. I guess I have to keep this practice up since it seems beneficial to others. Thank you so much for your feedback
0 - Kofi Nartey• 650
@kofinartey
Submitted
Hi everyone. This is my first published project since I begun learning to code. I'd appreciate it if anyone goes through my solution and suggest areas I could improve upon. Super happy to learn from y'all.
Kofi Nartey• 650@kofinartey
Posted
Uuuuuh. Learning something already; an HTML beautifier. Thanks man, I'll do well to look that up. Looking forward to writing cleaner code in the coming days
1 - Diegochits• 105
@mrdiegodev
Submitted
Any feedback is welcome. I'm just starting my journey as a web developer. I had a lot of trouble with de CSS Background property, i'm sure there are better ways to code that section.
Thanks :) mrdiegodev
Kofi Nartey• 650@kofinartey
Posted
This is pretty impressive mate. I took on this challenge today and it hasn't been that easy. Still struggling to complete it. Especially with the background. You did well
1
