P
@GeorgeGit1
Latest solutions
Newsletter Subscription UI with Carousel Slider (Responsive Design)
#sass/scss#bemSubmitted 15 days agoI'd really appreciate any feedback, especially on the fluid layout part. I found it a bit challenging to wrap my head around and get it just right.
Responsive Dynamic Content Time Tracking
#sass/scss#bemSubmitted 25 days agoI'm happy to hear any feedback or suggestions.
Responsive & Semantic Article Preview with Simple transition
Submitted 2 months agoI would like feedback on the readability of my code, as well as the clarity of my naming conventions for variables, class names, and functions. I'm aiming to write clean, well-documented code and would appreciate any suggestions for improvement.
Latest comments
- @kristianusdianata
Good job!!
- @zaeemarshad1122What are you most proud of, and what would you do differently next time?
Im proud that i did it
What challenges did you encounter, and how did you overcome them?I encountered challenging fetching the data.
What specific areas of your project would you like help with?Any help is appreciated
@kristianusdianatagood job!
- @lh62863@kristianusdianata
good job!
- P@EmLopezDevWhat are you most proud of, and what would you do differently next time?
I would say I most proud of the validation for the form. Although it is simple I just enjoyed working through it and getting to work well. Also going the extra few steps on adding a disabled state to the button and having the UI show the entered email on the success card.
One thing I would do different is the card layout I could have made it reusable instead of creating two cards one for each state.
What challenges did you encounter, and how did you overcome them?- getting the list aligned with the custom bullets. Just had to surf the internet for a solution. Turns out you just do it all directly on the
liselector. - changing the focus state look of the input. I couldn't get the blue outline to go away, until I noticed you could by setting
outline: none.
- I would say mostly I would like feedback on the JS. I think I did everything well but is there something I missed or could have done better.
@kristianusdianataFirst of all, congratulations on completing the challenge, the result looks quite good both visually and functionally. I really appreciate the effort and thought you put into this great work!
Marked as helpful - getting the list aligned with the custom bullets. Just had to surf the internet for a solution. Turns out you just do it all directly on the
- @Shreyas1008What are you most proud of, and what would you do differently next time?
- i made a div inside a div which made me difficult to position to their place
- js part makes me think when to click and when to not click
@kristianusdianataFirst of all, congratulations on completing the challenge and the result doesn’t look too bad visually. However, when I looked at your code, I noticed that you're not using semantic HTML, and the responsive layout is a bit unpolished. Additionally, on small screens, I found that the back button in the share menu disappears when I move the cursor. Overall, good job and keep it up!
- @mtrejoafa@kristianusdianata
good job
