@Huseyn823
Submitted
If you have any advice for me you can comment
Looking to hire developers?
@krutagna10
@Huseyn823
Submitted
If you have any advice for me you can comment
@krutagna10
Posted
You can use picture tag instead of using two images inside a div.
@Mayur-1182
Submitted
@krutagna10
Posted
Marked as helpful
@krutagna10
Posted
Hello @smayrant I wanted to know how did you make designo favicon.
@vanzasetia
Submitted
Hello Everyone! 👋
This is my 30th solution on Frontend Mentor! Also, it's my first Advanced challenge. This was a large project and fun project. I learned a lot of new things. 😎
I learned how to create an accessible hamburger menu. It required me to use an inert
attribute. inert
is an HTML attribute that prevents users from interacting with the interactive elements. Currently, it has 82.97% support by the time I finish this challenge. But, I still need to use a polyfill for browsers that don't support inert
attribute.
Progressive enhancement was also something that I apply when I did the challenge. Usually, when the users disable JavaScript, I will hide all the page content and tell them to turn on JavaScript. Now, I make it possible to interact with the site content without JavaScript. 🙌
Now for the questions:
input
by reading the label and the placeholder of the input. For example, TalkBack pronounces the input
name as "Edit box, name, name.". Narrator only read the label of the input (expected behavior). So, is that okay?This is a large project. I might miss something or do things in bad practice. So, if you notice something wrong or there are things that I could have done better, please do let me know. 🙂
Also, if you have finished this challenge and would like me to give feedback on it, please include a link to your solution. I would be glad to help you! 😀
Thanks!
P.S. I wrote everything that I learned on the README.md
. You should check it out to see some of my approaches to solving the tricky parts of the challenge. 😉
@krutagna10
Posted
@vanzasetia I have one question, if you are using scss then why are you not nesting the selectors ?
@kiangopez
Submitted
If you notice, I have gaps between the pictures under the hero component. What should I do to remove those? I appreciate critiques and feedbacks!
@krutagna10
Posted
You have to make the display of those images from inline to block to remove those gaps.
You can always add this code at the starting of your css file to make images easier to work with.
img {
display: block;
max-width: 100%;
}
Marked as helpful
@correlucas
Submitted
👾 Hello, Frontend Mentor coding community. This is my solution for the Testimonials Grid Section.
Feel free to leave any feedback and help me improve my solution or make the code clean!
🤩 I had a lots of fun building this challenge! Mainly because I understood how to apply a focus effect on the card hovered with only CSS and I've also created my own design changes and personal improvements to the challenge elements.
SPECIAL THANKS to @elaineleung that show me how to add different animation stats for the cards in the intro.
I added some features:
I'll be happy to hear any feedback and advice!
@krutagna10
Posted
This comment was deleted
@AdrianCsT
Submitted
@krutagna10
Posted
👾Hello @Cydr4l, Congratulations on completing this challenge!
I think you can add a paragraph saying "Kindly select a rating" when the user does not select any rating.