Steve Mapute• 20
@devstevv
Submitted
Kyle Kasprzyk
@kylekasprzyk
All comments
- Kyle Kasprzyk• 260
@kylekasprzyk
Posted
Great job on your solution!
Instead of using pixels in
font-size, use relative units like rem or em. The font-size in absolute units like pixels does not scale with the user's browser settings. Check out this article.Example
font-size: 0.875rem;To clear out the accessibility report warnings, wrap your
<div class="container">content within a<main></main>and your<div class="attribution">content within a<footer></footer>.After committing the changes in GitHub, come back to this solution page and click generate new report. It should clear out the warnings.
Happy Coding!
1 - EmilianoGomezA• 30
@EmilianoGomezA
Submitted
Kyle Kasprzyk• 260@kylekasprzyk
Posted
Great job on your solution!
Instead of using pixels in
font-size, use relative units like rem or em. The font-size in absolute units like pixels does not scale with the user's browser settings. Check out this article.Example
font-size: 1.375rem;Check out the wall of fame page and you'll find some inspiration from other members in the Frontend Mentor community.
Happy Coding!
Marked as helpful
1 - StivenCodes• 150
@StivenShiquito
Submitted
Kyle Kasprzyk• 260@kylekasprzyk
Posted
Great job, @StivenShiquito!
I'm very new to web dev, but one thing you could add to match the "active state" design is
cursor: pointer;under.btn:hoveron line 86 of your index.css file.Happy coding!
0 - aps8778• 10
@aps8778
Submitted
It was good,if color was also given and font it would have been more easy
Kyle Kasprzyk• 260@kylekasprzyk
Posted
Looks good. Check out the style-guide.me in the starter.zip. This will provide the layout, colors, and typography.
Marked as helpful
0
