Looking to hire developers?
@leecockcroft
@leecockcroft
Submitted
Can Someone explain to me how this is well off pixel perfect? I have gone through the figma file and have done all padding the same ( I think)
But the design/solution shows its well off! Also the gap between the text and the boxes at the bottom "10k, 314 12m" On figma the gap is a lot bigger than the "solution" here. I have checked this on 1440px screen, It looks perfect to me, then I Submit it nd its well off? Am I doing something wrong?
@leecockcroft
Posted
it was me :)
All sorted. Just needed an increase in fonts
@leecockcroft
Submitted
Please could someone advise best practice for submitting the form and obtaining the value. I was able to get the email value and add this to the text, however I couldnt add the error message. putting required on input and onsubmit, my js didn;t work.
Any other advise/tips please let me know.
@leecockcroft
Posted
Thank you for your help
Follow me on Twitter as I am about to start the 100 Days of code https://twitter.com/leecockcroft20
@leecockcroft
Submitted
I found I got myself in some unexpected problems. Ideally I wanted to have all the filter options on top of the page once selected, and removing the tab the filter would refresh. How would I do that? You can click on the tab and they all work accordingly.
Should I have approached this a different way? As this was practice there may be some ambiguous variables eg let x = .....! The only way I will get better is if someone could look at my code and advise me, what am I doing wrong? where should i approve? All advice would be appreciated.
Thanks
@leecockcroft
Posted
Hi Roman, Thank you for your feedback.
Yes I checked your code, I had a few issues using the svg as an "img" so I just embed it and swaped via JS, which obviuously didn't make it responsive.
"As for js part - you should probably insert all the content into html, and only in js aplly filter functionality. "
Usually I do, the only reason I did it this way was due to all the information being in an object, I thought it would be easier running a script (so I'n not repeating myself)
Future projects is it wise to separate, HTML,CSS,JS as much as possible? even if it takes longer?
Also, if I did separate them all, would it have been a very simple, event handler, and using my switch statement to get grab the relevent data tags?
I used this approach as I tried to use the same mentality as using React.
Many thanks for your feed much, it's much appreciated Lee
