Skip to content
OverviewSolutions
7
Comments
8
Lira
@lirapanci

All comments

  • Lira•190
    @lirapanci

    Hello,

    Nice work.

    I'd suggest some minor changes in order to make the project perfect. Since this is a form, every input of it should be filled in order to proceed to the next step; The buttons on the steps on the left should be able to click, for instance, if you're in the second step, you can click step 1 and go back to it; The last thing is that when you click the toggle button and go to a Yearly membership, all the prices as well as the acronyms for monthly (mo) should change to Yearly (yr).

    Cheers, Lira

  • Lira•190
    @lirapanci

    Hi,

    Nice job.

    I suggest you make some minor changes so you can have a pixel-perfect implementation.

    1. The 15% tip, should not be automatically selected and the color that the 15% button has, should be the color of the tip selected (active).
    2. Can't be zero message should disappear when you enter the number of people.

    Cheers, Lira

  • Lira•190
    @lirapanci

    Nice work. Just something that you need to fix at the custom percentage: When I have set a custom percentage and then I click on another Percentage button, the Custom Percentage value should be emptied. Cheers :)

  • Lira•190
    @lirapanci

    Hi there,

    Congrats on completing the challenge. It's a really nice job. I think that you might want to check the total/person value, which remains unchanged despite the number of people you add.

    Cheers,

  • Lira•190
    @lirapanci

    Hi there,

    Congrats on completing the challenge. It's a really nice job. I think that you might want to check the total/person value, which remains unchanged despite the number of people you add.

    Cheers,

  • Lira•190
    @lirapanci

    Hello,

    Congrats on completing your challenge. There is some stuff that I'd suggest you may consider fixing on that. When clicking the Reset button, the number of people should be cleared too. The custom tip percentage is not clickable, and the user cannot add any value. And also, the tip percentage buttons are only selected after you click on the second button (either DoubleClick or click on another percentage).

    Cheers,

    Marked as helpful
  • Lira•190
    @lirapanci

    Hello,

    I've just finished the same project and it was really challenging also for me, considering my "level of expertise" in Javascript :))) I'd suggest you use the eventlistener ("keyup") to track changes on all the inputs, so you can remove the Submit button.

    Cheers,

    Marked as helpful
  • Lira•190
    @lirapanci

    This is my first challenge from Frontend Mentor. I prepared the Interactive Rating Component using Tailwind CSS and Javascript. Considering I am just starting out with Javascript, any feedback will be appreciated.