@TejaswiniLabade
Submitted
Hi, I completed testimonials site using CSS Grid. Any feedback is really appreciated.
Looking to hire developers?
@lucasweidas
@TejaswiniLabade
Submitted
Hi, I completed testimonials site using CSS Grid. Any feedback is really appreciated.
@lucasweidas
Posted
Good job in that one!
You have a problem centering the main
container. To fix it, just add these lines to your body
tag.
min-height: 100vh;
display: flex;
justify-content: center;
align-items: center;
Then, remove the margin: 100px auto 0;
line inside your media querie in .container
.
Keep it up!
Marked as helpful
@louisenorrsen
Submitted
I am very happy with this solution! This is the first time that I get really close to the design image!
I would like feedback on how I can make the code more effective, it feels like it is a little bit unorganized right now.
Thanks!
@lucasweidas
Posted
Good job on that!
Something I think you need to improve: change the div
in payment-btn
and cancel-order-btn
to a button
tag. Use div
only as a generic container.
Keep it up.
Marked as helpful
@ankithapai
Submitted
i dont know how to use github well as of now hence i cant host it
@lucasweidas
Posted
great job on that one!
First of all, you have two folders with the same name, but the first one is useless. So, you need to move your second folder called qr-code-component-main out of the first one, and add on your Webdev folder. This change will make the github page identify your index.html and the page will work just fine.
Keep it up.
Marked as helpful
@alt-plusF4
Submitted
Feedbacks, please! Thank You.
@lucasweidas
Posted
Nice work on that one!
But you need to wrap all your main content, in this case it is div class="bg"
and div class="mid"
, inside a main
tag. Also, you can wrap your div class="attribution"
within a footer
tag.
Keep it up!
Marked as helpful
@nakoyawilson
Submitted
Any suggestions on how I can improve are welcome!
@lucasweidas
Posted
Nice job, Nakoya Wilson!
I see a small problem with the background-image
in your body
. To fix it, just set this code.
@media (min-width: 1440px) {
body {
background-size: 100% 52.5%;
}
}
Marked as helpful
@laurstevenson
Submitted
Still grasping responsive designs, mobile version still needs some work (troubles with border-radius). Any feedback would be appreciated!
@lucasweidas
Posted
Greate job, Laura!
To fix the "main" landmark problem, you need to wrap the "div.panel" with the "main" tag.
To fix border radius trouble, change the "@media (max-width:500px)" to "@media (max-width:899px)", and the two class ".pricing-plan" inside them, to:
.pricing-plan:first-child { border-radius: 10px 10px 0 0; } .pricing-plan:nth-of-type(3) { border-radius: 0 0 10px 10px; }
Sorry for my bad english :)