Fer Siqueiros• 30
@psiqueiros
Submitted
This is my first project ever, I'm transitioning from tutorials and courses to the real life workflow. I realize my code is messy so be gentle, any feedback is much appreciated.
Luis Delgado
@luisdevworks
All comments
- Luis Delgado• 365
@luisdevworks
Posted
Hello Fer,
For being your first project, it is very good, I like it.
About your code, I think you should use better names for the classes, it's just my opinion, I suggest you check the BEM Method, in my case, helped me a lot. The BEM Method is in most cases for bigger projects but as I say, helped me to understand better the context of organizing my code between HTML and CSS.
I also noticed that the transition from mobile to desktop the background didn't change..
So I checked your code and you can add this code to fix it
@media only screen and (min-width: 769px) { //You can add this to change the background body { background-image: url(../images/bg-desktop.png); background-color: hsl(229, 57%, 11%); background-size: 100% 50%; background-position: bottom; background-repeat: no-repeat; }
Keep doing good work!
1 - Sophie• 75
@0sophietaylor
Submitted
This is my first attempt at building a site from scratch on my own - I would love some feedback!
Luis Delgado• 365@luisdevworks
Posted
Hello Sophie,
Looks great for the fact is the first site built from scratch. I have some issue with the design of the indicator, please check if you can fix that.
Next time it would be great if you learn some responsive design for small gadgets, I'm pretty sure you will improve a lot your design.
Good Job!
0 - Sebastian Urbaniec• 170
@surbaniec
Submitted
Hello everyone! This is my first challange and I'd like to know if I'm using BEM and SCSS in good way. Thanks for all responses.
Luis Delgado• 365@luisdevworks
Posted
Hello Sebastian,
You're using BEM and SASS in a good way, in my opinion.
Besides that, I have some observations.
The color of the share button should be different when it's clicked as you see in the design, you can change the svg code with css and apply using JS when clicks.
The bottom of the card should have also a border radius.
And finally, what about the desktop design?
For everything else, works great, and it's very good for your first challenge!
Keep going, good work!
1 - Luis Delgado• 365
@luisdevworks
Submitted
Any feedback is well received
Luis Delgado• 365@luisdevworks
Posted
Hello Hendra,
Thanks for the feedback, I'll check and fix the issues!
0
