Skip to content
OverviewSolutions
57
Comments
5
P

David

@lumiukoTbilisi, Georgia1,910 points

Hey, welcome to my profile 👋. My goal is to complete ALL Frontend Mentor challenges. Currently, I've completed all Newbie and Junior challenges. Most of the Newbie solutions are private since they're pretty simple.

I’m currently learning...

Advanced React, TypeScript

Latest solutions

View more solutions

Latest comments

  • Ortaly•1,190
    @ortalyarts
    What are you most proud of, and what would you do differently next time?

    This solution selects the correct color scheme chosen based on user's computer preferences. Please let me know if it doesn't work on your machine :) or if you spot any other issues.

    Responsive Github user search app. Fetch API. Light/dark themes.

    1
    P
    David•1,910
    @lumiuko

    Hello, great solution so far. I've noticed some small bugs in your app.

    1. If I type something into the text input and press enter, it refreshes the page. You can fix this behavior by adding the "submit" event on the form instead of "click" on the button and using event.preventDefault.
    2. When the text input is empty and I click "Search", the image seems like it can't be loaded. To improve UX, you can just not do anything but display the error message near the button.
    3. On mobile screens, the error message overlaps the input field and placeholder.
    4. Also, in the mobile view, I can't scroll the content. The solution is to remove "overflow: hidden" from the body.
    Marked as helpful
  • P
    David•1,910
    @lumiuko

    Very nice animations, well done!

  • P
    David•1,910
    @lumiuko

    Hey, great solution so far. You can also use object-position: left on the image to make it even closer to the design.

    Marked as helpful
  • P
    David•1,910
    @lumiuko

    Pixel-perfect 👍

  • P
    David•1,910
    @lumiuko

    Nice one! It's almost pixel-perfect