Lawrence Webber
@lwebbzAll comments
- @Melbita@lwebbz
This looks perfect, well done
- @codingat17What specific areas of your project would you like help with?
I need help with the desktop view.
@lwebbzYour mobile solution is great, well done!
For the desktop layout, you can add a media query that changes the flex direction to row once the viewport goes beyond a certain width, with something like this.
@media (min-width: 760px) { main { display: flex; flex-direction: row; } }
- @ougwYTWhat are you most proud of, and what would you do differently next time?
neste projeto minha compreensão das tags e suas funcionalidades aumentou e para proxímos buscarei adcionar uma api.
What challenges did you encounter, and how did you overcome them?o desafio da vez foi a estilização da imagem e da caixa rosa que. que foram superados com o auxílio do youtube.
What specific areas of your project would you like help with?tentei aplicar uma api de receitas culinárias no projeto mas não consegui aplicá-la. como faço para introduzir apis nos projetos ?
@lwebbzWell done on completing the challenge however there are a few things that can be improved on here.
- The image isn't centered
- Fonts are incorrect
- the spacing between each section is too much
- The instructions list should use <ol> not <ul>
- Only the first few words of each instruction should be in bold and not the whole line
- The nutrition table only has a single column instead of two
- Lastly, there is only a desktop design but no mobile design
You should try and pay a little more attention to the details in the style guide, you will get a lot more out of it then and no need to rush to creating an API before you master the basics.
- @lwebbz@lwebbz
Super helpful thanks, have updated my code accordingly!
- @jsemenborodas@lwebbz
Looks great, only detail is the font-weight of the name and location should be bold
- @BlackpachamameWhat challenges did you encounter, and how did you overcome them?
¿Sabían que es posible hacer toda la tarjeta clickeable sin afectar la semántica del código? Podemos ampliar el área clickeable del enlace para que abarque toda la tarjeta utilizando
pseudo-elementos
, sin necesidad de envolver todo el contenido en un<a>
.Esto lo descubrí gracias a la comunidad de frontendmentor en discord, les recomiendo darle un vistazo y participar de la misma.
@lwebbzperfecto
- @aleegaarza@lwebbz
LGTM!