Looking to hire developers?
@mahnoork18
@pbatista01
Submitted
Hello World! This is an updated solution of the project Clipboard Landing to practice and improve HTML, CSS and responsive web design skills. I fixed the errors and took the advises given to improve the site. Let me know of anything else I could been missing.
@mahnoork18
Posted
Hey, nice work there! I have noticed a few things that need to be corrected. firstly, the float property in CSS is outdated try using flexbox or grid for layout so that you can have fewer lines of code. also, you need to add alt text in your HTML. Hope this helps!
Marked as helpful
@Shikhar0411
Submitted
@mahnoork18
Posted
Hey, nice work there! I would like you to suggest a few things: Try to wrap in the <main> tag to make it more structured, also you should keep your content part in a single div it will help you manage it well. For the responsive part, I would like to suggest you add a (max-width-768px) media query to take care of the mobile and tablet versions. also, add max-width to the container for mobile design. Hope this helps.
Marked as helpful
@MuhammadM1998
Submitted
3 Attempts just to get the solution preview working! Had a bit of a problem getting the columns at equal size with flexbox, found this article and it turned out to be very helpful and i learned new things about when and why do we use flex: 1 or flex-basis: 100% and what's a better approach. Totally recomended. https://css-tricks.com/equal-columns-with-flexbox-its-more-complicated-than-you-might-think/ First time to to use BEM for HTML classes and it's really useful. Would appreciate any feedback.
@mahnoork18
Posted
This is pixel perfect layout! Good Job
@ZeyadTa
Submitted
I want a feedback if anything is not done with the best way to do it.. and thank you.
@mahnoork18
Posted
hey, add background-repeat no repeat to your css.
Marked as helpful
@saykeed
Submitted
please i would like a feedback on the way i spaced those elements using margin and paddings. i hope that is not the kind of code they call spaghetti code
@mahnoork18
Posted
Hey nice work, your code is clean and readable. I would like to suggest you use rems for padding it will help you more than pixels.
Marked as helpful
@viplavg
Submitted
I dont know how to position exactly the background-Image So that part is little bit wrong.
@mahnoork18
Posted
hey, nice work there! suggestion from my side you need to add background-repeat:no-repeat to the body so that wave doesn't repeat. and make its width 100% too. good luck (Y)
