Skip to content
OverviewSolutions
9
Comments
8
Marc REGNIER
@marc-regnier

All comments

  • coyoteshkw•150
    @coyoteshkw
    What challenges did you encounter, and how did you overcome them?
    • Propagation

    JavaScript has Propagation, so when I want to make a func to click on card and pop-up share card disappeared, it didn't work.

    I read doc and using event.stopPropagation(); to solve this.

    shareBtn.addEventListener("click", (event) => {
  event.stopPropagation();
  shareBoard.classList.add("up");
});
    • width: 100%

    I found using width:100% rather than max-width: 100% on this situation is better.

    add object-fit and object-position

    .card__img img {
  width: 100%;
  height: 200px;
  object-fit: cover;
  object-position: center;
}
    What specific areas of your project would you like help with?

    Can I only make the pop-up display outside the card by canceling overflow: hidden?

    Responsive article preview component

    1
    Marc REGNIER•100
    @marc-regnier

    Great job ;)

  • Marc REGNIER•100
    @marc-regnier

    Html and css well structured. good work ;)

  • Max•260
    @maxkdavis
    What are you most proud of, and what would you do differently next time?
    • learning to use css grid
    • better understanding of the box model
    • continuing to practice css grid
    What challenges did you encounter, and how did you overcome them?
    • how to properly use css grid
    What specific areas of your project would you like help with?

    .

    Testimonial Grid with CSS Grid and Media Queries

    1
    Marc REGNIER•100
    @marc-regnier

    your code is well structured in html and css. It's very good work ;)

  • Coke Stuyck•130
    @cokecancook
    What are you most proud of, and what would you do differently next time?

    Added animations on mobile to simulate the hover styles on desktop

    What specific areas of your project would you like help with?

    Code optimization and use of a system

    Four card feature section

    1
    Marc REGNIER•100
    @marc-regnier

    good work and good idea to add a hover effect on the cards.

  • Marc REGNIER•100
    @marc-regnier

    The border-radius on the button is missing on the desktop version and the shopping cart icon is missing.

    good job ;)

  • paulDev•660
    @dev-paulL
    What specific areas of your project would you like help with?
    • What would be the expected accessibility features on this type of component? I guess each category should be accessible with tab key?

    Frontend Mentor - Recipe page

    2
    Marc REGNIER•100
    @marc-regnier

    Great work, but be careful with the dimensions and the font, as they're not the same as on the model. Otherwise, the HTML is well structured.

  • HrishiD89•50
    @HrishiD89
    What are you most proud of, and what would you do differently next time?

    This time i was clear what i was doing and took less time then my first challenge

    What challenges did you encounter, and how did you overcome them?

    nothing in particular; it was fun, hoping to practice more and more

    What specific areas of your project would you like help with?

    I will attempt to replicate them in React in the future.

    Social links profile page using html and css

    1
    Marc REGNIER•100
    @marc-regnier

    The html and css are well structured and well done ;)

  • Marc REGNIER•100
    @marc-regnier

    Good work, but you forgot the links in the html file for the font to take effect.

    <link rel="preconnect" href="https://fonts.googleapis.com" /> <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin /> <link href="https://fonts.googleapis.com/css2?family=Outfit:wght@100..900&display=swap" rel="stylesheet" />