I didn't quite understand the responsive part. The designs looked the exact same to me so wasn't sure what was expected.
I'm happy with the result and I refreshed my memory on certain things.
What challenges did you encounter, and how did you overcome them?No real challenges here, Google-foo FTW.
What specific areas of your project would you like help with?None
Links aren't working for me but screenshot looks like design :)
I am most proud of using proper BEM formatting when styling my SCSS styling. I think this helps keep my CSS readable for another user.
What challenges did you encounter, and how did you overcome them?One of the main challenges was learning how to properly do the margins and use the box model correctly. I was able to overcome them by understanding the difference between content, padding, border, and margin correctly.
What specific areas of your project would you like help with?Because the nature of this design is rather narrow it already works well on smaller phone screens. I would like feedback on the responsiveness of the design. Do we always need to use media queries? Or for a design like this is it okay to design it such that it works on the smallest screens first, and then progressively gets bigger?
The solution looks really good to me. It was my first project using SAAS so it was good to see you are using it too. The only thing I can think of is design rules say most pages should have an h1 then the next h tag should be h2 then h3 etc. You shouldn't jump from an h3 to an h6. I think this is beneficial to screen readers.
In regards to your question about responsiveness, the design for this between the different screen sizes is only a slight adjustment to the width so I think its ok not to have media queries for this particular challenge. I think it would be different if on the larger screens the buttons were horizontal and then they changed to vertical at a smaller screen size.
Well done. Keep up the good work!
This is an excellent implementation of the project. You are using semantic html and thinking about accessability. I really like the transition you have added to the hover.
It looks like you have a really good understanding of html and css and are using things I haven't seen before :)
Literally the only thing I can think of is the README for the project mentions hover and focus states so I took that as meaning the header had to be an anchor tag. Your solution has a hover but nothing to focus on (if someone was using the keyboard instead of a mouse). But that might my misunderstanding of it :)
Keep up the good work!
The solution looks excellent to me. Liked the way you have imported the google fonts, haven't saw it done like that before.
You are using semantic html and have provided an alt text on the image for accessability. The only thing I could possibly suggest is have the main part in a <main> tag since you also have a <footer> but having it as a <div> is perfectly fine.
