Skip to content
OverviewSolutions
5
Comments
6
mdohr07
@mdohr07

All comments

  • mdohr07•70
    @mdohr07

    Looks good and solid, on first sight almost the same as the original. My critiques would be the little triangle below the tooltip, it's a bit off - like there's some tiny space between. Also if you decide to just have the share-menu displayed on mobile view, the share-button becomes useless. Hope that helps :)

  • mdohr07•70
    @mdohr07

    Looking at you live site I think in the mobile view your main container could take up a bit more space/be bigger and I would recommend to change the cursor to a pointer when hovering the little share button. But the mobile view of the tooltip is so good! Smart idea!

  • mdohr07•70
    @mdohr07

    Apart from the background color it looks close to the original. Since the CSS is in Tailwind by the looks of it, I couldn't really review that one. But yay for Astro and good job :)

  • mdohr07•70
    @mdohr07

    Looks pretty good :) Checking your Code I would suggest giving variables easy-to-understand names. Just for the future - if you'd be working with others, they might not know what --db, --mb, or --lb refer to or what they stand for. Even you might not remember if you came back to a project after a longer break :P I like that you put the links into a list!

    Marked as helpful
  • yahia5034•50
    @yahia5034
    What are you most proud of, and what would you do differently next time?

    using of the font and how to use font-face.

    What challenges did you encounter, and how did you overcome them?

    The font variables. by doing lots of search.

    What specific areas of your project would you like help with?

    i would like a review and is what i did with the font right or needs to be improved

    Responsive blog-preview-card using html and css

    1
    mdohr07•70
    @mdohr07

    It looks pretty close to the provided samples and the responsiveness works really well. I also like that you included a h1.error and the @fontface import which personally I have never used, so I can't really comment on it. But I want to try it too now :D My critique would be clean code - the CSS could look tidier

  • mdohr07•70
    @mdohr07

    Looks pretty good! Just checking the code you could have added aria-labels to the HTML and personally I think having a h1 instead of an h1 would have been better. But overall nice and clean :)