@hec-lopz
Submitted
Looking to hire developers?
@miguelseguramx
@hec-lopz
Submitted
@miguelseguramx
Posted
You have a really good solution, it's a really cool animation on mobile! ;3
@Sudhar611
Submitted
Please provide your valuable feedback for the below questions. These questions are based on the problems that I faced while developing the solution.
@miguelseguramx
Posted
¿Have you try to use an <img> tag and give it the svg on the src attribute?
@ksenius
Submitted
I hid the chat app and its focusable elements from screen readers with aria-hidden="true"
and tabindex="-1"
. Should I have made it accessible?
P.S.: I hope the animations aren't annoying.
@miguelseguramx
Posted
The animations are really cool!
@DannyBrito
Submitted
Thank you for checking my solution. I am trying to improve my css skills, any and all feedback is welcome.
@miguelseguramx
Posted
You have a really well organized JS, what if you could achive the same effect with only Css???
Check my solution: https://www.frontendmentor.io/solutions/article-preview-without-js-using-checkbox-GRi3wnWXJ
You could improve it because my social media container it's weird when the page is loading
@TiaraOluwanimi
Submitted
Comments are welcome
@miguelseguramx
Posted
You create the progress bar and the circle with two ::after elements
I would be better if you create a span element to make the progress bar and a span::after to the circle.
This way the circle would always follow the progress bar.
@Ranveer251
Submitted
I am new to React, I was not able to create hover effect on the social icons. I tried using hooks but for every icon I have to make a new state and make functions for each of them to handle their hover effect. Is there a short way of doing this?
Is there a way that in the mobile size when the hamburger menu is clicked the scrolling of the body is disabled?
@miguelseguramx
Posted
To achive the effect on the icons you can use :hover https://www.w3schools.com/csSref/sel_hover.asp
And maybe the css property: filter https://www.w3schools.com/CSSref/css3_pr_filter.asp
@chrisstolba
Submitted
Nit picking.
Not sure how to make the background pentagram
thicker like in the design example.
Not sure of a convenient/graceful way to transition the open rules
button's position as the screen height shrinks without effecting the rules modal
. This happens at heights shorter than the height of the rules background
~750px.
Why does my generated screenshot appear 'short'. It looks fine when I visit the site directly.
@miguelseguramx
Posted
This is a wonderfull version of Rock, Paper, Scissors, Lizard, Spock! This is Amazasing! I love it! :3
@VJones2112
Submitted
I have a ton of questions!
I started this project by sectioning off and styling with only divs. That worked fine on the small-screen, but I couldn't figure it out on the desktop version. Using display:grid was much easier. How would I do it if I wanted to stick with just divs?
What is the difference between the desktop-design.jpg and the desktop-preview.jpg?
I considered using h1, h2, p tags to set up the sections, but I remember an accessibility tutorial said screen readers use those to kind of summarize a page and I wasn't sure if that was applicable here, so I just styled <p> tags. Thoughts on that?
I felt like the opacity of the paragraphs was different than what I styled, but is that maybe just a difference in colors?
Finally!- In the Why Us section, I originally set it up as a ul, but then changed it to using <br>. Is one way preferred over the other? Or is there a different preferred way to do this?
@miguelseguramx
Posted
This's a cool project
Using a grid is the best way to create someting like this, you can use: https://cssgrid-generator.netlify.app/
desktop-preview.jpg is to show a general view of the project, it has more sense if you have multiples states and pages,
If you were working on a real pricing component, you made the right decision In this case, the pricing component is all the content of the page, I don't see why not use h1 or h2 tags
it could be the opacity but if you want to change the color, you can use Chrome Dev Tools to achive the right color! I have a small tutorial on my instagram @miguelseguramx
You should use an ul because you would have a syntactic HTML, the content it's a list, so you need to use a tag for a list
Try to indent your HTML code, because you are writing for yourself and for other developers
The tag body has weid margin, you should override the default styles of some tags
You're doing a good job, keep it up!
@miguelseguramx
Submitted
@miguelseguramx
Posted
I'm using sass because I need to practice for my next job!
@claireporter26
Submitted
Hi, In this project I have tried to use the BEM method to organise my CSS but I sometimes get confused about the best class names to use and how to write them so it would be good to have some feedback on how I can improve these going forwards. I am also new to using SASS so any recommendations with how I can improve this or look into other elements of SASS that would help in this type of project would be great.
Thank you.
@miguelseguramx
Posted
There's an issue on the images, they are stretched, it's a really important thing