Prince Roy• 1,210
@iprinceroyy
Submitted
I have used sass/scss, I want feedback on my styling which I adopted to solve this challenge. Any feedback would be really appreciated.
Ali Mousavi Nizhad
@mnizhadali-afg
All comments
- Ali Mousavi Nizhad• 270
@mnizhadali-afg
Posted
This is very cool. Keep it UPPPPP :)
0 - Josh Eberharter• 380
@jeeberharter1
Submitted
Any feedback would be greatly appreciated :)
Ali Mousavi Nizhad• 270@mnizhadali-afg
Posted
Well done :)
1 - giorgi• 140
@Lomsk1
Submitted
if u have some notice, please tell me
Ali Mousavi Nizhad• 270@mnizhadali-afg
Posted
Good work :)
Marked as helpful
0 - Mubeen Shaikh• 160
@MubeenAhmadShaikh
Submitted
Hello all,
So I tried with starting the sunnyside challenge on frontendmentor. This is my first solution submission I would really appreciate the feedbacks from community.
Thanks, Mubeen
Ali Mousavi Nizhad• 270@mnizhadali-afg
Posted
Nice work :)
1 - kevin• 90
@estivenson94
Submitted
I noticed that there are some errors and also a repeated .svg id improving little by little.
Ali Mousavi Nizhad• 270@mnizhadali-afg
Posted
Good work mate.
Marked as helpful
0 - AnaesthCode• 100
@AnaesthCode
Submitted
Im open and very grateful of anyone that takes their time to give me feedback to improve.
Ali Mousavi Nizhad• 270@mnizhadali-afg
Posted
Nice work.
0 - Karim• 210
@karimseh
Submitted
Really enjoyed this one! feel free to give a feedback, Thank you.
Ali Mousavi Nizhad• 270@mnizhadali-afg
Posted
great :)
0 - Fraser Watt• 1,790
@fraserwat
Submitted
Tried out a new methodology for this, CUBE CSS (there's a good walkthrough of the rationale and a sample web page here). Really really liked this, it's quite utility focused but you don't end up with having to remember 1,000 utilities and make your HTML look incomprehensible like you do with Tailwind (but maybe I'm just using Tailwind wrong!). I feel like my CSS is less repetitive and I feel like I wrote less of it than usual (although that might be due to the relative lack of complexity in the project, and would be difficult to measure given the amt of auto generated classes in the config).
Still going to take a bit of getting used to but I think I'm going to bring this more into my CSS more generally (it works really nicely with SASS).
Towards the end I think I got a bit hacky and there's probably a better way I could have done the layout for Desktop than making the hero image and the stats list
position: absolute... Any ideas here?Ali Mousavi Nizhad• 270@mnizhadali-afg
Posted
Hey mate, Nice job and keep it up.
Tip: Always remember to use the generic elements inside the Semantic elements. The HTML Semantics are always for wrapping the HTML elements and giving meaning to them.
Good luck :)
Marked as helpful
0 - Heba Ibrahem• 180
@heba-ibrahem
Submitted
Ali Mousavi Nizhad• 270@mnizhadali-afg
Posted
Nice work Heba. Keep it up!
0 - Call Seven• 110
@callseven
Submitted
Ali Mousavi Nizhad• 270@mnizhadali-afg
Posted
I think the link for the code is wrong!
Marked as helpful
0 - Anosha Ahmed• 9,340
@anoshaahmed
Submitted
Would appreciate any advice on where and how to get better. Thank you x
Ali Mousavi Nizhad• 270@mnizhadali-afg
Posted
@anoshaahmed - Brilliant Anosha Jan! I have issues with the challenge (Profile Card), can you help with that, please?
1 - Anosha Ahmed• 9,340
@anoshaahmed
Submitted
I used desktop-first approach for this, and now I know for sure that mobile-first approach is best.
Please let me know what I can do to improve.
Ali Mousavi Nizhad• 270@mnizhadali-afg
Posted
@anoshaahmed your works are awesome and great. I admire it ;)
Marked as helpful
1 - Ali Mousavi Nizhad• 270
@mnizhadali-afg
Submitted
Just updated the final version :)
Happy coding to everyone.
Ali Mousavi Nizhad• 270@mnizhadali-afg
Posted
@anoshaahmed - Thank you so much dear Anosha :) And again, the final edit is at github repo! It did not change here :P
0 - Ali Mousavi Nizhad• 270
@mnizhadali-afg
Submitted
Just updated the final version :)
Happy coding to everyone.
Ali Mousavi Nizhad• 270@mnizhadali-afg
Posted
Thank you so much for feedback. How much should be the value for (vh) in body?
0
