@fwirsch
Latest comments
- @mubaraqwahab
Impressive!
- @SebaFarias@mubaraqwahab
Man this is good! Keep up the good work 🎉
- @JDFIREX@mubaraqwahab
Great! Here's a tip to fix the accessibility issue in your report: Give the input a label and make the label visually hidden.
- @MuhammadHassaanMahmood5550@mubaraqwahab
It looks like you're missing the background-image behind the phones. The footer should also have a dark blue background colour. Everything else looks good 👍🏾
- @mgtachen@mubaraqwahab
Well done! I have some comments to share:
-
You have a
<div class="bottom">that contains a<div class="left">Below.bottom, you have a<div class="right">. The closing tag for.bottomcomes before.right. Moving the closing tag below.right(i.e. moving.rightinto.bottom) should fix the responsiveness issue, I guess. -
I suggest you rename your
index1.htmlto justindex.html. The design preview here isn't showing the right thing. (It probably expects anindex.htmlfile) -
A tip: You have a
<div class="button">. You could use a<button class="button">(or a link). I read an article regarding this: When To Use The Button Element
All the best :)
-
- @fodare@mubaraqwahab
Hey.
I'm guessing you added
border-radiusto#Single-Priceand it didn't work. It looks like some<div>s inside#Single-Pricehave theirbackground-colors set and noborder-radius, so their sharp edges flow out of#Single-Price. A quick fix would be to addoverflow: hiddento#Single-Price.Second thing. I noticed you used a
<table>to layout the "$29 per month". I've read it's not good (for accessibility, for example). Use a<table>for "tabular" data. In your case, you can use<div>s instead, or<span>s, or something, and style with CSS.All the best!
