Emmanuel Munyite• 290
@munyite001
Submitted
As always, feedback is highly appreciated :)
Emmanuel Munyite
@munyite001
All comments
- Emmanuel Munyite• 290
@munyite001
Posted
Thanks @Eray, really appreciate the helpful tips, I am working on them immediately
0 - Emmanuel Munyite• 290
@munyite001
Submitted
Feedback is highly appreciated :)
Emmanuel Munyite• 290@munyite001
Posted
Thanks, reply appreciate the tips, will start working on them immediately
0 - TRG• 150
@MugeshTRG
Submitted
Ok, I have 2 questions for the community.
I based this card on a grid layout. The right part of the grid (containing the image), scales when resizing but the image's proportion gets smaller while the left part pretty much stays the same. (If you don't get what I'm saying, please try resizing the webpage given in the view code section.)
Next, I created a div that overlaps the img for the color. The container and the div works correctly but if you notice closely, the img leaves a small space on the bottom. I've given scaling to 100% but there is always some space on the bottom where the img is.
Please provide guidance to these queries. Any other suggestions are also welcomed!
Emmanuel Munyite• 290@munyite001
Posted
Also try experimenting with height 100% to see how it behaves
0 - TRG• 150
@MugeshTRG
Submitted
Ok, I have 2 questions for the community.
I based this card on a grid layout. The right part of the grid (containing the image), scales when resizing but the image's proportion gets smaller while the left part pretty much stays the same. (If you don't get what I'm saying, please try resizing the webpage given in the view code section.)
Next, I created a div that overlaps the img for the color. The container and the div works correctly but if you notice closely, the img leaves a small space on the bottom. I've given scaling to 100% but there is always some space on the bottom where the img is.
Please provide guidance to these queries. Any other suggestions are also welcomed!
Emmanuel Munyite• 290@munyite001
Posted
Hey @MugeshTRG
I see what you mean, if you are using a grid layout, and assuming you'll have two divs for the text and the image, you could just set the width of the image to 100%, so that it will always match the width of its parent div
0 - Fernanda• 180
@ferlagher
Submitted
Hi everyone, I just want to know if it was correct to use the article tag for the card or I should used a div instead. Thank you!
Emmanuel Munyite• 290@munyite001
Posted
Hey, Article tags are just okay, but they're mostly used to separate different parts within a given section. My opinion is it's better to use a div to denote the entire card, to act like a container, then you can use article tags for the different sections in your card, like the image section, or the text section. But overall, really nice design. Happy coding!!
Marked as helpful
1
