Skip to content
OverviewSolutions
17
Comments
13

Neil Kanakia

@neilk17Underground300 points

Mostly breaking things

Latest solutions

View more solutions

Latest comments

  • Neil Kanakia•300
    @neilk17

    Hi Jav,

    Great job with completing this challenge and at making it responsive

    If you don't mind, here's some small improvements you can make:

    Accessibility issues: <html lang="en"> just ensure that all of the content is indented within this tag.

    Responsive Design: I think you have done this part perfectly

    Overall this is great and good luck for your other challenges.

  • Neil Kanakia•300
    @neilk17

    Hi Vaibhav,

    Good job with completing this challenge!

    If you don't mind, here's some improvements you can make:

    Accessibility issues: This has an easy fix, rather than using <h5>, try to just increase the value by one and then change the font-size in styles.css.

    Purple Filter I was also not able to figure out how to add the purple filter overlay to the image, if you figure out how to do this please let me know!

    Hope this helps, and let me know if you have any other questions.

  • Neil Kanakia•300
    @neilk17

    Hi Vishal,

    Good job with completing this challenge

    If yo don't mind, here's some improvements you can make:

    Accessibility issues:

    These are easy fixes such as using html landmarks (<main>, <header>, <footer>) instead of putting all of your content inside <div> tags.

    Font: The font that is in the design is provided in the style-guide.md file, where you can go to google fonts, add the font and paste the link into your html / css document.

    Centering Content :Rather than using display: absolute, you can effectively center your content using css Flexbox, by putting the code in a container and using

    display: flex;
align-items: center;
justify-content: center;

    Responsive Design: I would suggest taking a look at Media Queries to understand how to make a website responsive, which just means it will look good on a mobile device with a smaller pixel width.

    Hope this helps, and let me know if you have any other questions!

  • Neil Kanakia•300
    @neilk17

    Hey Reymart,

    congrats on completing this challenge you have done a great job especially with the share button.

    Here's some other suggestions:

    HTML issues:

    • These are easy fixes such as using using href inside the <a> tag instead of <a link=``>
    • Adding an alt text in your images as a description for accessibility

    Flexbox: You can effectively center your content using css flexbox, by putting the code in a container and using

    display: flex;
align-items: center;
justify-content: center;

    Hope this helps, and let me know if you have any other questions.

    Marked as helpful
  • Neil Kanakia•300
    @neilk17

    Hey Francisco, Congrats on completing this challenge and good job on making it responsive!

    I don't think you need the line 113 styles.css is required. Here's some other suggestions:

    • Accessibility: These are easy fixes such as using html landmarks (<header>, <main>, <footer>) instead of <div> tags to contain most of the content.
    • Flexbox: You can effectively center your content using css flexbox, by putting the code in a container and using
    display: flex;
align-items: center;
justify-content: center;

    Hope this helps, and let me know if you have any other questions.

    Marked as helpful
  • Neil Kanakia•300
    @neilk17

    Dear Emily, congrats on completing this challenge!

    Here's some advice for your solution: Colors: The colors for the text have been provided in the style-guide.md file. This can be done simply by adding the color attribute in your css file.

View more comments