Skip to content
OverviewSolutions
18
Comments
24
Nick C.
@niemal

All comments

  • Nick C.•690
    @niemal

    Updated with github-pages client-side routing, react-window working on all devices for all content!

  • Nick C.•690
    @niemal

    Updated with greater main animation depth, fixed animation cluttering.

  • Nick C.•690
    @niemal

    Hello there,

    First off congratulations 🎉, I believe you put in some good effort in getting this done. I will be pointing out something on the mobile version:

    The second tab has the footer bar floating in the middle, you might want to take a look at that!

    Wish you fun and joy going forwards!

  • Nick C.•690
    @niemal

    Hello there,

    This looks pretty solid congratulations! I have a suggestion to make, at least on the mobile version:

    When you click on an upvote button, the button hover-states and remains hovered. You might want to do something about that and remove the hover on mobile or just make it a keyframes animation on mobile.

    Last but not least fixing the accessibility report on this page should also be a fine task to take on.

    Overall solid, love it, keep it up!!!

    Marked as helpful
  • Nick C.•690
    @niemal

    Hello there,

    Just want to note that in the mobile version the cross icon does nothing (is supposed to remove the entry).

    Looks decent btw!

  • Nick C.•690
    @niemal

    Hello!

    The planet animations are just amazing 😍, very nicely done! I do not have access to a desktop right now so I will be commenting on the mobile version.

    I have a suggestion: you can preload some images in the header so as soon as the crew page is visited for the first time, the experience looks as sharp as possible!

    Besides that, this looks really solid, well done. Will get back for the desktop version if I find something that can be improved on there.

    Marked as helpful
  • Nick C.•690
    @niemal

    Hello there,

    First off, this looks quite decent, congratulations. However I think you forgot to implement the responsiveness for the mobile version, you might want to take up on that one!

    Cheers.

  • Nick C.•690
    @niemal

    Hello there,

    I must commend your effort in creating such an engaging and user-friendly experience. I will be doing this review for the mobile version of the website.

    I would like to bring to your attention a few areas that could benefit from further refinement. Firstly, I encountered a "scroll burglar" issue that hindered the smooth navigation of the web page. Addressing this problem would enhance the overall user experience and make browsing more enjoyable.

    Secondly, I noticed that the "filter by region" button was not functioning as intended. Ensuring that this feature works seamlessly would significantly improve the usability.

    Lastly, within each country's dedicated page, I found that the border buttons were not linking to the actual country page so perhaps that's a feature to implement.

    Kind regards and best wishes!

  • Nick C.•690
    @niemal

    Hello there!

    First of all, I want to commend you for the effort you've put into completing this challenge. I can see that you've paid attention to various details, and the overall design is quite impressive.

    While reviewing your project, I noticed a small oversight regarding the focus-ability of <a> elements. It appears that the :focus state styling is not applied to these elements, which could impact the accessibility and user experience for some users, especially those relying on keyboard navigation.

    I hope this helps!

    Marked as helpful
  • Nick C.•690
    @niemal

    Amazing job man, very nicely done 👍!

    I would like to recommend preloading all the images to improve the experience on the first loads with those beautiful animations. And also I would like to point out there's a small gap on the mobile home page at the bottom, probably need to do something about that!

    Besides that, one of the best implementations in my humble opinion. Keep it up!

    Marked as helpful
  • Nick C.•690
    @niemal

    Hey there,

    The accessibility report is a good place to start getting feedback from, perhaps you would like to start from there. I have no access to a desktop right now so I will be reviewing the mobile version only.

    The implementation looks lovely overall but there is something that should be noted and fixed: when I click on the small dots below the feedback cards nothing happens. I expect the horizontal scroll view to scroll on a specific card when that happens.

    That's about it for all I can look at right now, wish you fun going forwards!

    Marked as helpful
  • Nick C.•690
    @niemal

    Hello there,

    I just want to mention that you perhaps forgot to review the mobile menu. Aside from that it looks pretty good to me!

    Regards.

  • Nick C.•690
    @niemal

    Hello there,

    Right now I don't have access to a desktop or laptop so I can't review such devices therefore I will stick to mobile.

    First off, I would like to mention that a good starting point is reviewing this page's accessibility report which indicates for semantic errors.

    Secondly, it looks quite decent, nicely done! I can only make a suggestion about the mobile menu, perhaps you would like to switch the menu icon to a cross icon when it's open so there's a clear clarification on how it closes. A good area of expansion is learning about animations which can spark some magic as well. ✨

    Wish you a great journey into web development!

    Marked as helpful
  • Nick C.•690
    @niemal

    Hello there!

    First off I would like to mention that the design implementation looks quite solid and I would like to congratulate you on that. Now to pinpoint some potential issues:

    1. Review the accessibility report errors and try to fix them.
    2. When typing "google.com" in the input field, it says I need to type a valid link. Perhaps reconsider making it strict to "https://" or "http://", you can indeed just post plaintext "google.com" to the API and get the same result. If the link is invalid, you can let the API itself derive that conclusion.
    3. There's also a scroll-burglar on the mobile version. You should reconsider the fixed width on something (I won't spoil!).

    Keep having fun on the journey of web development, regards!

    Marked as helpful
  • Nick C.•690
    @niemal

    The top section animation with the smooth roll-up is just beautiful. Good job!

  • Nick C.•690
    @niemal

    Very impressive I liked this a lot, keep it up!

  • Nick C.•690
    @niemal

    Hello there!

    Looks pretty good keep the effort up! I would like to point out just one thing:

    There's a scroll burglar on the mobile view. You should probably do something about it!

  • Nick C.•690
    @niemal

    Greetings!

    As a CSS in JS fan myself I welcome you to the cool side of web development 😎. I don't have access to a desktop/laptop right now so I will be reviewing the mobile version only.

    1. The slideshow of the gallery crashes when I hit either button.
    2. You will probably want to make a disabled add to cart button state for when the product was added.

    Best of luck and wish you lots of fruitful development!

    Marked as helpful