@JulioCezarSabim
Submitted
Hey guys, this project took me a while to finish. The design isn't exactly like the template, but to be honest, I don't think it's so important to be. I would appreciate any feedbacks. Thanks.
Looking to hire developers?
@nkhatri7
@JulioCezarSabim
Submitted
Hey guys, this project took me a while to finish. The design isn't exactly like the template, but to be honest, I don't think it's so important to be. I would appreciate any feedbacks. Thanks.
@nkhatri7
Posted
Hey well done on completing this challenge! The overall functionality seems to be pretty good. The only thing I'd suggest is adding hover states for the border countries buttons and the back button on the details page. Also if you want to make the flags look better on the cards, I'd suggest using object-fit: cover
and making them all the same height and width so there's a consistent look. Other than that the design and code look great!
Marked as helpful
@BenjaDotMin
Submitted
Hello all! I decided to up the stakes and try my hand at a Junior level challenge.
Here I learned how to:
As always, any time spent is very much appreciated!
@nkhatri7
Posted
This is really well done! The javascript code is really efficient and just done well overall. The design is also really good, the only thing I'd call out is when the screen width is between around 700px to 1000px, the period filters are too spread out. I think it would be better if you did justify-content: center
and then spaced them out a bit with margin
(but still keep them rather centralised). Other than that, I can't really fault your code and design, keep up the good work!
Marked as helpful
@bajajharsha
Submitted
Hey Guys Pease let me know if you have any feedback that can make it look better.
@nkhatri7
Posted
Hey Harsha,
Just a couple of things that I think will be helpful:
<main>
and <footer>
in your code. It's better for SEO (search engine optimisation) so it's a really good thing to have in your code. For this challenge, it would be good to wrap the card within <main>
tags and the attribution within <footer>
tags.<h1>
tag, this is important for SEO once again and indicates what the most important text on a page is.position: absolute;
top: 50%;
left: 50%;
transform: translate(-50%, -50%);
px
as your unit in CSS and use more relative units such as rem
.Hope this helps :)
Marked as helpful
@jongvelasquez
Submitted
Hi everyone! I just completed this preview card component desktop, activate state and mobile responsive. Feel free to give feedback and suggestions on what to improve. Thanks
@nkhatri7
Posted
Hey Jaime,
First of all the design looks great! One thing you should always try to remember is to use semantic HTML so in your case, it would be good to wrap your main content (the card) with <main>
tags. Furthermore, you should always have a <h1>
element, so instead of using <h3>
, you should use <h1>
as it's the main piece of text or heading for that page.
Another thing is that for links that don't have any text (e.g. social media icons or images), you want to include an aria-label
attribute in the <a>
tag for accessibility purposes as it would help screen readers.
Other than that, you're doing well so keep coding!
@nitish2101
Submitted
@nkhatri7
Posted
Hey Nitish,
Just a couple of issues I picked up with the UI and functionality:
font-weight: lighter
for the styling of those elementsMarked as helpful
@igor-ostojic
Submitted
Any better way to do the responsiveness besides a bunch of media queries ?
Thanks in advance !
@nkhatri7
Posted
Hey Igor,
First of all, the design and code look great! So one way of adding more responsiveness is using vw
and vh
. These are relative units that respond to the dimensions of the viewport, so vw
is 1% of the viewport width and vh
is 1% of the viewport height. Now I wouldn't recommend using these relative units on their own, it's probably better to use them along with a base size in a calc()
function (e.g. calc(10rem + 10vw)
).
P.S. I noticed in your HTML file you used the <head>
tag inside your main, I'm assuming you wanted to use <header>
instead?
Hope this helps :)
Marked as helpful
@codeDavidC
Submitted
Are the naming conventions, best-practice, or syntax correct? Please let me know. Thank you!
@nkhatri7
Posted
Hey David,
The layout and your code look great! The only thing I'd suggest is using Semantic HTML. So for example instead of writing <div class="main-content">
it would be better to use <main>
. This blog post by Vincent Bidaux has a good explanation of what HTML5 semantic elements are and why they are beneficial.
But other than that, great job!
Marked as helpful