@lh62863
Latest comments
- P@oryanhach
I have not learnt React yet so I am not on a place to criticize your code. But just one thing I think is missing, and is the background color, and centering the card, other than that it looks great!
- @PxMachWhat are you most proud of, and what would you do differently next time?
I'm just proud to have finished
What challenges did you encounter, and how did you overcome them?I had a little trouble with my Responsive Design
What specific areas of your project would you like help with?I am listening if you have any suggestions for improvements to offer.
P@oryanhachIt looks great! As I am a beginner, there is only one thing I would suggest, using custom properties. I recently started using them as well after watching Kevin Powell's videos. While this is a smaller project and it may be overkill, it could still help with avoiding mistakes like in terms of wrong color values.
Marked as helpful - P@LisviksP@oryanhach
This looks great! Much better than what I did! One thing I would suggest is just making the vertical lines a little bit thinner, but overall this solution looks so good, really pixel perfect!
- @SortJakkeP@oryanhach
Looks great, much closer to the original than mine! One thing I would suggest is just to center the overall grid. I used flex to put it in the middle of the page when working on the Desktop design.
- @PresidentTree94What are you most proud of, and what would you do differently next time?
I simply followed the original project and coded the solution with HTML and CSS, but I also added a Dark Mode function in Javascript. Next time, I would like to try it in other frontend languages like ReactJS.
What challenges did you encounter, and how did you overcome them?Like the last project in the unit, I did not have the Figma to reference so it was a lot of guessing and checking to get it to match the challenge as close as possible. So far, this one was the most challenging to match.
What specific areas of your project would you like help with?I am still learning the other frontend languages, such as ReactJS, so any advice involving them would be helpful. A React extension may also be included on GitHub.
P@oryanhachThis solution looks great! I am a beginner, so I might be wrong, but I have learned many things while watching your code. One thing I would suggest is improving your custom properties' names to make them more descriptive and consistent.
For example, instead of using --white for a color, try something like --color-white, which makes it clear that it's a color value. Similarly, for --davysGray, you could consider something like --color-davys-gray to maintain consistency in naming. Also, for --gridMinWidth, a name like --grid-min-width might be clearer.
Making these small changes can help improve the readability and maintainability of your code, especially as your project grows. Keep up the good work!
- @kristijanbobovecWhat specific areas of your project would you like help with?
Every advice would be helpful.
P@oryanhachHi, the solution looks great! I am a beginner so not really suitable for giving tips on that, but if I would recommend one thing is, check out Kevin Powell's code along video on this project! I followed his video, I have learnt many tips and techniques from this video.
