All comments

• 

  Kira Weizman Shapira• 90

  @kirawesh

  Submitted over 1 year ago

  • what was difficult to do for me:

  • centering all the content.

  • I would like to know if there better workflow to did the solution.

  

  Frontend-Mentor-Product-preview-card-component

  2

  2

  0

  

  Osman Nuri ERDOĞAN• 310

  @osmannurierdogan

  Posted over 1 year ago

  Hello @kirawesh,

  You did good job buddy :) In my opinion, there are some points that you should improve.

  One them is proper usage of class names, you are accessing the elements with their tag name such as h1, p, div etc...

  The other one is that you need to improve your responsive layout skills. When your code goes to mobile layout, it does not automatically align self to the center, and font-sizes for mobile layout is way bigger than it should be.

  I hope my feedback will be helpful for you,. Also you can check my profile to see my solution or you just click this link (https://www.frontendmentor.io/solutions/product-preview-card-component-using-html-and-css-sass-X8Ysx64Wu0)

  Take care, see you.

  Marked as helpful

  1
• 

  Amobi Jonathan Chukwudi• 350

  @Errorman2003

  Submitted almost 2 years ago

  How do you center your div perfectly?

  

  QR code solutions using HTML and CSS

  #accessibility

  2

  3

  0

  

  Osman Nuri ERDOĞAN• 310

  @osmannurierdogan

  Posted almost 2 years ago

  Hi @Errorman2003,

  I centered the div with the following code for this challenge. It may not be the perfect solution but it works for me. :D If you have better solution, you can reply my message, I would be happy for that :)

  .customDivItem{ position: absolute; top: 50%; left: 50%; transform: translate(-50%, -50%); }

  0