dngtnv• 190
@dngtnv
Submitted
It's good to have something to do in my free time. Please let me know if there is anything I can improve on.
Adriana Eka Prayudha
@radenadri
All comments
- Adriana Eka Prayudha• 160
@radenadri
Posted
Hello dngtnv, congratulations it's a great work! 👏🙌
The layouts and the elements are match the design, and the dark mode toggle works as well!
But i found one specific issue and one addition based on my opinion, especially in mobile (<= 425px) viewport :
-
The top padding on social-media container are blocking the dark mode toggle, so the toggle can't be clicked. I believe the solution for this you can add margin-top to this container on mobile breakpoint, maybe 40px is enough and you good to go!
-
Since the user id element contains image and text, i think you can use span element to wrap the elements, because span acts like a div but for inline element, and for the text you can wrap it in p tag. Because p tag mostly used for text only. 😁
Reference : https://developer.mozilla.org/en-US/docs/Web/HTML/Element/span
That's it from me, keep coding! 👏🙌
Marked as helpful
1 -
- mabrur• 105
@mabrurherza
Submitted
My 2nd challenge built with plain html and css. I sprinkled the icons with basic motion using css 🍨 and will be triggered (using JS) when the cursor hovers the card. Also works on mobile screen, but since there's no hovering state it will be triggered when you clicked the button. ✌
Adriana Eka Prayudha• 160@radenadri
Posted
Great work man! The layout works great & the animations run smoothly in every device width! 🙌
I have several additions based on my opinions :
- If you increase the line height on the text a little bit, say it at least 2 or 2.15 i think it'll be great 😃.
- The button hover state works perfectly! But if you also change the text color to match the card background color, that would be more match the design as well!
- There's a horizontal overflow on smaller width, you might wanna check what's going on 😊.
Overall it's a great work, congratulations! Happy coding and also keep coding man! 👌👏
0 - dngtnv• 190
@dngtnv
Submitted
This is my first time doing a challenge here. Please review my code, it helps me a lot.
Adriana Eka Prayudha• 160@radenadri
Posted
Nice work man! It works greatly on tablet and mobile as well! 🙌
From what i see, i think i only have two additions based on my personal opinions :
- It will be much more awesome if you add the box-shadow on each testimonials, just a thin shadow to make it look exactly like the design. But overall its great, its only little additions as well. 😊
- I believe the provided design showing that the avatar is kind of small, if you change it to approximately 45px, i think it will be much more great since it will be much more clearer to see the picture.
That's it, great work for sure! Happy coding and also keep coding man! Waiting for another work! 👏👌
Marked as helpful
1
