Skip to content
OverviewSolutions
8
Comments
6

Rafael Takano

@rafaeltakanoGoiânia, Goiás.180 points

Em graduação no curso de Sistemas de Informação (UFG).

Latest solutions

View more solutions

Latest comments

  • Rafael Takano•180
    @rafaeltakano

    Hello there 👋

    Great job on getting started, please keep going! There are a few things I think it would help.

    As pointed out, we can't see your exemple on the live site, the index.html file should be at the root of your project folder.

    After you replace the index.html file to the correct place do not forget to change url locations and stylesheet links like <link rel="stylesheet" href="/css/style.css"> to the correct path.

    Your BEM looks good and the structure is correct.

    Hope this helps 🤞

    Marked as helpful
  • Rafael Takano•180
    @rafaeltakano

    Hello there 👋

    Great job on your solution, it looks great!

    About the accessibility issues, your html should have at least one main landmark and the page should be contained by html landmarks.

    About sass, good job using sass, you used sass nestings really well. To make it shine even more, take a look at the BEM pattern design for css.

    Hope this helps ✌

    Marked as helpful
  • Rafael Takano•180
    @rafaeltakano

    Hi there! ✌

    Great job on your solution! It looks great and it's responsive!

    About your question, the html { margin: 0 } will make the <html> tag have margin of value zero.

    using the * selector, it will set all tags the value of margin: 0, not only one tag

    Hope it helps!

    Marked as helpful
  • Rafael Takano•180
    @rafaeltakano

    Hello There ✌

    Great job on your solution!

    The accessibility issues at your report are about not having landmarks elements on your page, if you include it it will be fine!

    Hope it helps, happy coding 😁

  • Rafael Takano•180
    @rafaeltakano

    Hi, Luciano! 👋

    Nice work on this challenge! ✌ Your solution is responsive and looks great! 👍

    About BEM, it is a methodology that has Blocks, Elements and Modifiers (B.E.M).

    Blocks that have Elements related to it should be named [Block]__[Element]

    And only modifiers should have the double dash [Block]__[Element]--[Modifier]

    An exemple:

    //css
.button {}

.button__text {}

.button--green {}

.button--blue {}

//html
<button class="button button--green">
      <p class="button__text"> Green Button </p>
</button>

<button class="button button--blue">
      <p class="button__text"> Blue Button </p>
</button>

    I hope this helps!

    Marked as helpful
  • Rafael Takano•180
    @rafaeltakano

    Hello there ✌

    To fix the part of the container gonne missing at moblie view, you'll need to refactor your code to work without the position absolute on the class .container

    And the accessibility issue at the report card, its only about the .attribution class that it is not wrapped with a landmark tag, wrap it on a <footer> and it will be fixed!

    Hope It helps!

    Marked as helpful