Latest solutions
REST Countries API with color theme switcher - React Router
#accessibility#react#react-router#styled-components#viteSubmitted over 2 years agoAge Calculator - Constrain Validation API
#accessibility#bem#sass/scss#lighthouseSubmitted over 2 years ago
Latest comments
- @clarabacker@raubaca
Hi Clara,
One thing you can improve is to change the card number
input
type from "text" to "number" and hide the input arrows with CSS. You can also set amin="0"
attribute to the input so people don't input negative numbers.Good job!
Marked as helpful - @klabruben3@raubaca
Hi Ruben, some observations:
- You don't need to add
<br />
in the HTML to generate spaces, just use the CSSmargin
property. - The title font is different from design, try to adjust the
font-family
andfont-weight
properties. - The selector
.card.one button:nth-child(8)
can be simplified to.card.one button
.
Good job!
Marked as helpful - You don't need to add
- @Gustavo-Victor@raubaca
Hi Gustavo, you can improve the title by adding some spacing between the letters and increasing the font weight:
.title { ... letter-spacing: /* spacing value */ font-weight: 700 /* included with google font import */ }
Good work!
Marked as helpful - @newtothis90@raubaca
Hi,
You can improve your code by learning semantic HTML elements. For example, you can replace the container
<div id="container" role="main container">
with<main id="container">
. Another thing could be, don't use ids (#id) for styles, use classes (.class) instead. Good work!Marked as helpful - @monimunozalzate@raubaca
Hi Monica,
Your solution is visually excellent, but I have encountered some issues:
- When I filter by region, the region name doesn't appear in the select.
- After filtering by region, the search input is disabled.
- When I search by name, the item link in results is wrong, it is the same as the previous item in that position.
So far that's all I've found, great job!
Marked as helpful