Skip to content
OverviewSolutions
11
Comments
12
razanabbas
@razanabbas

All comments

  • razanabbas•150
    @razanabbas

    Your code is good, i like that you used JS to fetch the data from data.json and generated the HTML accordingly.

  • razanabbas•150
    @razanabbas

    Your code is neat and well written

  • AllisonFavour•170
    @AllisonFavour
    What are you most proud of, and what would you do differently next time?

    The javascript part being able validate the email efficiently and also displaying the pop up as intended

    What challenges did you encounter, and how did you overcome them?

    The email validation and the pop up, did some research to come up with efficient and precise solutions

    What specific areas of your project would you like help with?

    Always open to new ideas and suggestions for improvements

    Newsletter sign-up form with success message, using scss, flex and js

    2
    razanabbas•150
    @razanabbas

    I think your code is neat and well-written

  • Ye-Won Seo•170
    @yaywonah
    What are you most proud of, and what would you do differently next time?

    I'm proud that I kept going on this project, despite restarting it twice. I learned more about using the position property and custom CSS properties.

    What challenges did you encounter, and how did you overcome them?

    I had trouble figuring out how to code the share button on mobile and desktop. I looked at tutorials on YouTube for help and also general tutorials on the position property.

    What specific areas of your project would you like help with?

    I'm having trouble aligning the share button with the user pic and name/date on the bottom of the card, especially in mobile view. I'm guessing that it's because I coded the share-btn in a separate div from the info in my HTML?

    As for desktop view: I'm stumped on why the bottom of the container is falling off in the generated screenshot. It looks normal on my desktop. I think it's because of how I used the margin to push everything down.

    Article Preview Component with JS

    1
    razanabbas•150
    @razanabbas

    good

  • P
    Daniel Tefe•90
    @awaritefe
    What are you most proud of, and what would you do differently next time?

    Kept the JS very simple and easy to read. If i done it again id try one of the other css preprocessors.

    What challenges did you encounter, and how did you overcome them?

    I wanted to avoid sass and just style it raw as i dont get to do that much professionally. Also was interesting googling a solution and picking one that was simple and easy to read and pick up if someone else looked at it.

    What specific areas of your project would you like help with?

    Would like to know how others would tackle this if they used a different solution.

    Article Preview Component

    1
    razanabbas•150
    @razanabbas

    good

  • f1r3•140
    @f1r3place
    What are you most proud of, and what would you do differently next time?

    I like how little CSS this whole thing took! The repo says I have more HTML than CSS, and I think that's great

    Don't really like that I couldn't get the spacing right and as a result there's a lot of empty space in the cards, but oh well

    testimonials grid using... css grid

    1
    razanabbas•150
    @razanabbas

    Your design is very similar to mine. The cards are longer than they should be and idk how to fix that tbh.

  • Markus•240
    @mhjarvis
    What are you most proud of, and what would you do differently next time?

    Finally started using Grid instead of Flexbox for everything.

    What challenges did you encounter, and how did you overcome them?

    Mostly trying to get everything aligned with grid.

    Four Card Feature Challenge

    1
    razanabbas•150
    @razanabbas

    great!

  • razanabbas•150
    @razanabbas

    You could've centered the card by turning the body to a grid and using place-content: center.

  • razanabbas•150
    @razanabbas

    The design is good overall but I have a few comments:

    1. The source document was not very satisfying to read. I think you could've done it with less divisions.
    2. I suggest you add some left padding for list items inside unordered lists.
    3. I also suggest you add some spacing between table rows.
    4. Your card is a bit wider than it should be. Try applying a max-width. That's all I personally have to say. I hope you benefit from my feedback.
  • razanabbas•150
    @razanabbas

    Does the solution include semantic HTML? Yes but imo the header could be divided into two sections: one for avatar and one for description Is it accessible, and what improvements could be made? Yes Does the layout look good on a range of screen sizes? I honestly do not currently have access to a range of screensizes Is the code well-structured, readable, and reusable? yes Does the solution differ considerably from the design? No

  • razanabbas•150
    @razanabbas

    Your code is semantically organized but I think the buttons should be edited in active not hover state.

    Marked as helpful
  • razanabbas•150
    @razanabbas

    Great!