Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All solutions

  • Submitted


    Hey,

    my 2nd project. It feels good, as compared to the first one I was far less struggling and I definitely made already some progress.. :)

    This time I tried to focus on using HTML5 semantic elements and using BEM. So I would be thankful if you could take a closer look on it.

    Honestly using BEM sometimes felt weird. My CSS is now definitely more structured but I felt like I'm blowing up my code and sometimes I didn't know what to do.. Especially with nested boxes I felt like it's getting complicated. For example while creating classes like review__authorname , review__authorname I asked myself if it wouldnt be better to create classes like author__name. But I guess that way I would break BEM naming conventions.

    Also the classes box-1, box-2 and box-3 were special as I asked myself if I should really create duplicate code just to follow BEM. In that example I decided to don't do it..

    I would be thankful if someone more experienced has some input for me. Also all sort of other suggestions are welcome.. :)

  • Submitted


    Hey, this is my first finished frontend project. I'm a unexperienced newbie so far and would be very thankful for your valuable feedback.

    Questions:

    • I tried to center the price grid with flexbox horizontally and vertically. For that I had to set the height to 100%. Problem: If I open the site on a small mobile device, I can't scroll. Do you have a solution for me? I tried stuff like to work with min-height, but it didn't help...

    • I wasnt sure when I should use dynamic margin/paddings and when I should use static ones. I decided to use for my layouts inside the boxes static paddings so that the result matches with the design mockup as good as possible. Is this a good practice that way or should I avoid static paddings in general?

    • Any other suggestions on what topics I should pay close attention for my upcoming projects?

    Thanks :)