
Nazarii Sabadash
@sabbadashAll comments
- @Rohan-DahalP@sabbadash
Hi! I have got a few ideas about your soulution.
-
Use semantic HTML by replacing the div containers with more meaningful elements like main and article
-
Consider using a tags styled as buttons instead of button elements since these are links
-
Instead of using IDs (#a, #b, #c, etc.) for buttons, consider using a single class and margin-top. This reduces code repetition
-
The box-shadow on the container could be softer for better visual appeal
-
Consider using CSS custom properties (variables) for colors to maintain consistency
-
The layout could benefit from CSS Grid or Flexbox for the buttons section
You're doing great! Keep going ;)
Marked as helpful -
- @user2830581What are you most proud of, and what would you do differently next time?
- Completing the project and getting it as close to the design files as possible.
- Fluid typography without the use of media queries. I ended up using the clamp() function to achieve it.
- Feedback on how to simplify my CSS, I think there may be some redundant styles I think it looks a bit bloated but not sure how to identify when and where to cut back.
- Feedback on my use of clamp() function for font sizes.
P@sabbadashawesome!
- @Muhammad-harissWhat are you most proud of, and what would you do differently next time?
I am trying js projects for better practice
P@sabbadashgood one, congrats! I would also change border-radius for image and whole card, also it seems like something wrong with the font. Keep going!