Anosha Ahmed• 9,340
@anoshaahmed
Submitted
Would really appreciate any constructive criticism and ways I can improve.
saira
@saira512dev
All comments
- saira• 130
@saira512dev
Posted
hey.just wanted to thank you.I realized your way of positioning bg image was too good and learnt it from you.So thank you!!!
2 - Jakub• 90
@jakub-ozog
Submitted
Could you please share any feedback about my index.html readability/accessibility? This was my first Sass project so I would be grateful for any advice in terms of Sass usage - what should be change there if it comes to the structure etc. In this project I have also used blending mode and webkit-filter in the image section - I was trying to be as close to the original as much.
I have some doubts in terms of mobile version (setting up the breakpoints) so if you have any comments/thoughts here, that would be great.
Thanks in advance for any help. Cheers! :)
saira• 130@saira512dev
Posted
Hey jacob,your solution looks better than mine. Accessibility issue in yours is of section tags.Since you are using section,you are also expected to give headings( <h2> <h3> etc) Since in this case,we dont have headings ,i suggest avoid using section here.I am also new to accessibility issues.Feel free to correct me if am wrong
Marked as helpful
0 - codeFliers• 60
@codeFliers
Submitted
I still want to use vanilla CSS. I have trouble with the center where i used 3 floats left with width %. Is there a better solution ?
saira• 130@saira512dev
Posted
Flexbox is a better choice
0
