@ralphvirtucio
salomasik
@salomasikAll comments
- @salomasik
great solution. I can't view the Preview site
- P@DevHussein@salomasik
One in one with the design is great!!!!!!!!!!!!!!)👍 See how it is displayed on mobile devices and it will be a plus if when you enlarge the screen on the desktop, everything will be the same as at 1400px. You can also add opacity to the photo on the left, I tried setting it to 0.85, you can experiment with these values. I would also add cursor: pointer and hover on the button for social networks and other links. Glad if I could help.
- P@NikitaVologdinWhat are you most proud of, and what would you do differently next time?
–tabbing works great for the menu in the small screen version. –smooth transitions for the menu and backdrop.
What challenges did you encounter, and how did you overcome them?One challenge was hiding the visually hidden menu for the tab button. If the menu is behind the viewport and there is set overflow:hidden on the parent with the pressing tab button next tab element will be visually focused and the visually hidden menu exposed. That was solved by dynamically controlling tabIndexes according isMenuOpen state and focusing the first element in the menu by the native focus method which was triggered by ref. Also controlled dynamically aria-hidden attribute for the open and closed menu.
What specific areas of your project would you like help with?If anyone has any ideas for closed menu implementation please be my guest.
@salomasikCool and very design-conscious. Some links do not respond to mouse hover. Cool animation on the mobile version!!!!!!
- P@nataliesmythWhat are you most proud of, and what would you do differently next time?
I'm proud of the way my solution turned out, and prioritizing accessibility from the start made it easier to maintain and check accessibility throughout building the form. Next time I would take more time to understand how the error messages work before starting in order to plan how to build the functionality more accurately.
What challenges did you encounter, and how did you overcome them?My biggest problems were aligning the error messages, which was surprising because usually I struggle more with JavaScript. I used stack overflow to help.
What specific areas of your project would you like help with?I would love feedback on my JavaScript, and how I can create cleaner, more concise code.
@salomasikCool! there is a problem when displaying a block with “Successful sending of message”, I tried giving the exact width and changing the Left and right properties
- @AymaneOnlineWhat are you most proud of, and what would you do differently next time?
Not using JavaScript for making the accordion work.
What challenges did you encounter, and how did you overcome them?I couldn't make the screen reader read the page as I wanted, it actually reads the questions but when I press "Enter" it doesn't read the answers.
What specific areas of your project would you like help with?I want some help with the accessibility. I couldn't make the screen reader (NVDA) read the answer when I press "Enter" of the corresponding question.
@salomasikCool! Close to the design. but there is a problem when the screen is larger than 1440 pixels, the top photo of the background does not expand.
- @wendyhamel@salomasik
Good job!
- @skyleranglh@salomasik
GoodJob!!!!!!
- P@mayor-creator@salomasik
Good Job! It would be even cooler to do it for tablets.
- P@flavin-jr@salomasik
It would be cool if on tablets the blocks with user activity were displayed in two or three columns depending on the screen size, and the block with user information was on top like on the mobile version. What do you think about it?
- P@flavin-jr@salomasik
Wow! Very close to design. Good job)
- @psdesignroWhat are you most proud of, and what would you do differently next time?
I have learned how to toggle classes in order to hide or show an element. I've also practiced a bit the positioning of the elements. This time I used a simple structure for the SASS, just one file, as there were one main component on the challenge.
Regarding JS, at first I've used a conditional construction to hide/show the share tooltip, but it didn't have a smooth transition, so I used a class toggle instead and played with opacity, which allows smooth transitions.
For future projects I want to try to position the tooltip based on the mouse position, not on some fixed values.
What challenges did you encounter, and how did you overcome them?The first challenge for me was the positioning of the tooltip on the desktop, then it took me some time to figure out how to get that arrow button on top, and then I remembered that z-index works only with position:relative.
Later I've tested 2 ways to hide.show the tooltip and kept the shortest one, which also has some smooth tranistions.
What specific areas of your project would you like help with?For this challenge I'm ok, but if you find something I can improve in my code, please share your thoughts!
@salomasikGood job
