@sedaryildirim
Latest solutions
Latest comments
- @simon7195
Perfect job! Closer to the original design as mine.
- @ameera-abed-aldin@simon7195
Looks perfect to me. Good job!
- @Ay-dotcode@simon7195
Nice job!
- @japaxapaWhat are you most proud of, and what would you do differently next time?
I started the code with mobile first in mind and used BEM to organize the code
What challenges did you encounter, and how did you overcome them?Styling list tags and setting the responsive code
What specific areas of your project would you like help with?Any feedback on BEM usage
@simon7195Well done!
- @randyrobson@simon7195
Hi! 😄
Your solution is really nice, I really like the little animation that moves when the buttons are hovered.
May I make a few comments :
- For the avatar, you used the background of your
divto insert your image. I think using animgtag would have been more appropriate, especially in terms of accessibility, as in your case you can't display alternative text (alt="avatar of ..."). - For geographic datas, a
ptag would have been more appropriate than anh2. - The
sectiontags defines important areas of a site. In the case of a linktree, adivorspanwould have been more appropriate. - Regarding fidelity to the proposed design, your dimensions differ a little from the model. It's a detail, but for some designers and customers it can be annoying.
- Your CSS is very short, I think that's great, especially since on my side they're usually longer 😓. However, I think you should use classes because in a larger project, using tags as selectors is a dangerous gamble and makes it difficult to read your code (especially if it's uncommented as is your case).
I hope you find my comment useful. Keep it up! ✌️
- For the avatar, you used the background of your
- @Satyam-Pandey677What are you most proud of, and what would you do differently next time?
Now I'm understand the html trees and all CSS properties
What challenges did you encounter, and how did you overcome them?None
What specific areas of your project would you like help with?none
@simon7195Hi there! I think you've got the wrong project. This is the QR code project.. 😕 You should replace the link if possible, it's a shame not to be able to see your solution and give you advice if needed.
