Skip to content
OverviewSolutions
19
Comments
4
Simon Hernandez
@simonhernandez

All comments

  • Simon Hernandez•615
    @simonhernandez

    Hola @Darkfenix013! Espero estes bien.

    Una forma de lograr esa separación sería agregandole un display: flex al span que tiene la clase "precio" y lo mismo con el span "time". De esa manera estarías convirtiendo esos span en contenedores flex, lo que a su vez te permitiría usar la propiedad gap para indicar la separación que quieres que tengan los elementos que estan dentro de los span.

    .time,
.precio{
          display: flex;
          gap: 6px
}

    Un saludo!

    Marked as helpful
  • Simon Hernandez•615
    @simonhernandez

    Hello Erik! I noticed a couple of things that might be worth taking a look at:

    -Inside the main element, consider separating each of the sections with section tags, that way you will have a clean and semantic HTML structure.

    -Each title should be a heading rather than a paragraph. Consider replacing the p elements for h2 and h3 elements, following a hierarchical order.

    -Consider adding a breakpoint for medium screen sizes.

    Keep up the good work!

    Marked as helpful
  • Simon Hernandez•615
    @simonhernandez

    Hello, Aranxa!

    Nice work on this solution. I really like the fact you are using semantic HTML, BEM and your CSS is very clean!

    I have some minor suggestions you might find useful:

    • I would consider setting a max-width on the Intro-section's content-container, so that it does not overlap the image on higher screen sizes (I noticed it because my display is 1920x1080).

    • In the media query, I would set the text-align property to initial on the Intro section h3's, State section h2, and Features section h3's, so that they align to the left as in the design.

    • As a minor improvement, consider adding focus styles to the interactive elements on the page.

    Hope you find this feedback helpful and keep up the good work!

    Marked as helpful
  • Simon Hernandez•615
    @simonhernandez

    Hello, Ponnuasamy! 👋

    Great work on this solution! I really like that it is responsive, and the fact you added a cool transition on the mobile menu.

    Looking into your code I thought of some suggestions you might find helpful:

    • On the Articles Section I noticed you gave a class to each of the individual articles (articles1, articles2, and so on) with the same styles. I think it would be more efficient to create a single .article class containing those styles and applying it to each article element, that way you get rid of redundant CSS. Same with the .navtext classes.

    • I would consider setting a max-width on the Article elements, so that they do not stretch all the way on tablet screen size. Same with the Feature elements.

    Hope you find this feedback helpful!

    Marked as helpful