@Spaceman-In-Disguise
Latest comments
- @snhmibby
Hey, instead of div's, try to use the html semantic elements (https://www.w3schools.com/html/html5_semantic_elements.asp). In order to reduce the classes used, take advantage of the ordering/element selection capabilities of css. Or better, use SCSS stylesheets, so it's easy to put some hierarchy. Personally, I'd try to keep all layout related things in CSS and only content related stuff in the HTML. So instead of <div class="column", just nothing or a semantic element. and then specify a column layout with css.
- @Saima422@snhmibby
Hello! Some general observations
- you can add node_modules in .gitignore and only leave json config files. The node_modules directory is so huge github won't even display all of it.
- If you go all the way to make a component, don't hardcode the order-values but have them passed in as parameters to have practice in building a reusable web component.
- you have a .scss file, but your code is mostly plain .css. Sass is great because the hierarchy of your styles can mimick the hierarchy of your HTML, which greatly improves read- and understandability.
Marked as helpful
