I finally was able to use BEM without any help, I did it in no time and I think it was great :).
What challenges did you encounter, and how did you overcome them?I had some problems with the buttons, I don't know if it is the best way to center it using margin, bu was the only way I found to center it
What specific areas of your project would you like help with?It looks good! However, I would use actual buttons instead of using list elements. It's easier to work with and better for the semantics. It also makes it easier to create reusable styling for a button element.
That's a neat solution. Good job! My only comment would be to maybe look over the HTML and make it more semantic. Otherwise, spot on!
I proudly say chnage the names,fonts,images,and information
Good job! You should really look at your markup code and see how you can improve the readability and accessibility by using better elements rather than just using generic divs.
It looks really good but it's not responsive and breaks on smaller devices.
Clean code and it's well identified.
What challenges did you encounter, and how did you overcome them?When I styled the main background of the document, the text on the top container had the background highlighting of the same backgroundColor. So, I removed the highlight by styling the text back to white. Not sure if it's the right thing to do.
What specific areas of your project would you like help with?Deep understanding of Media Queries in CSS.
I would look over the naming of elements and classes. Also, if you don't have a H1 or H2, don't start with an H3. It's the only heading there so make it a H1.
The styling is interesting. Maybe you should go over it and really see what everything is doing.
Just one very obvious thing is the <div class="attribution"> that is wrapping everything and styled with a pointer as a cursor. Why? :)
One thing that I am proud of is my use of understanding and application of the fundamental elements to this project.
What challenges did you encounter, and how did you overcome them?When I wasnt able to figure out the name of an element, I Had to use either co-pilot or look at different resources online.
What specific areas of your project would you like help with?I guess an easier way or a more compact way to write CSS. I use way too many properties when there should be a few main ones that can target most of the points. If there is anything like that that I can use, that would be great.
Hey there! First of all, great that you finished the assignment! If you don't mind, I'd like to give you a few pointers that will improve your code.
Let's start with the HTML, shall we?
You have a <section> with both a class and an id that tells me that this is a main element. But, this element wraps another element that actually is a <main> element.
I would swap those two and maybe even get rid of one of the <section> elements inside this <main> tag altogether. Just to make it more clean and understandable.
Secondly, I'd change the <h2> into a simple <p> since the text inside it is a paragraph and not another heading. Right?
Bottom line: the <main> tag should wrap all the content here and I would get rid of the class name and id that suggests that the <section> tag is the main container. Maybe also get rid of the <footer> as well since you are not using it anyway.
This means that you will have to re-structure your styling a bit, which is good. As you said: "I use way too many properties". I agree. I think you can structure your CSS better and slim it down quite a bit. There are a few doubles (line 55 and 56) and some messy over-riding properties that you need to look at. Also, try to stick to one single color value model (RGB, HSL etc). It makes it a lot easier to manage and read your CSS.
I hope this helps you on your way :)
