@Adnan0-IM
Latest solutions
Latest comments
- @stezor
Looks good
- @Sanya-ZgWhat are you most proud of, and what would you do differently next time?
Improving your skills.
What challenges did you encounter, and how did you overcome them?There were no problems.
What specific areas of your project would you like help with?In the mobile version, when I click on the button, a blue square appears. I thought it was overflow, and I turned it off, but it's still there.
@stezorLooks good
- @Dhruvmehta1311What are you most proud of, and what would you do differently next time?
I always wanted to complete this challenge. As this challenge tests the knowledge of state in React. I'm glad I completed this challenge within 4 hours.
What challenges did you encounter, and how did you overcome them?Only challenge I faced was with the calculations. As I'm not much strong with maths, but at the end I made it work.
What specific areas of your project would you like help with?With the calculations part. I would be happy if I get any hint about the calculations.
@stezorHi @Dhruvmehta1311,
aside from some styling issues, there's a problem of output. I got +/- Infinity output instead of 0 before all the input values were in and if bill amount was below 0 respectively. Maybe that's the number one thing to be improved, check if u have all the values before calculating the output. Also no feedback error message.
- @Robincredible@stezor
Looks good. One thing to note is daily/weekly/monthly selection in desktop mode should be vertical, not horizontal.
- @Sajad-Najafi@stezor
Looks good.
- @kadan-develop@stezor
Hey Daniel,
I have couple suggestions.
-
div.active-states > div.icons you used display grid to organize the layout. In this example we have horizontal (one-dimensional) layout we need to achieve. Flexbox is a one-dimensional layout system that aligns items in a single row or column, while CSS Grid is a two-dimensional layout system that arranges items in both rows and columns. Therefor I think flexbox is the way to go here.
-
I've seen that you choose to use !important rule. In my opinion it's best to stay away from it because it overrides specificity and can potentially create problems later on.
-
