suhaib52
@suhaib52All comments
- @DammyD@suhaib52
You did it in a very good manner. Your code is well structured and readable.
It would be nice if you start using semantic html tags, these tags would reduce the accessibility issues.
You can also use :root to define the colors and then call them by using var() in your stylesheet. When you use the colors as a variable than your css code will look more precise.
Marked as helpful - @almeida883@suhaib52
You did it in a very good manner. Your code is well structured and readable.
It would be nice if you start using semantic html tags, these tags would reduce the accessibility issues.
You can also use :root to define the colors and then call them by using var() in your stylesheet.
I do not understand why you create separate style sheet for mobile and desktop.
Marked as helpful - @sawsan-code@suhaib52
Good job! Your code is well structured and readable. For html, try to use semantic html tags. Semantic html tag would help to improve the accessiblity.
Marked as helpful - @stefan123283@suhaib52
It would be better if you use the semantic html tags because these tags would reduce the accessibility issues.
You can also define the body in more details to make it more better such as; body { width: 100%; height: 100vh; display: flex; align-items: center; justify-content: center; font-family: 'Karla', sans-serif; background-color: var(--grayishBlue); font-size: 16px; }
Also use the margin 0 auto on the card id so it should be in the center of the page.
It would be nice if you use classes more as compared to the ids.
Marked as helpful - @kathrryn1@suhaib52
Your code is well structured and easily readable. Good job! You can define the colors by using :root at the start of the style sheet and then call them by using var().
Marked as helpful - @myrojoylee@suhaib52
I think you need to use the position relative and then use bottom property to move the profile picture.
- @Shraddha-V22@suhaib52
Your code is looking clean. It would be great if you use classes as compared to the ids in the html, because use of classes considered best practice as compared to the ids.
Marked as helpful - @ajchinasa@suhaib52
It would be great to use semantic tags than the div, because semantic tags improve the accessiblity.
You can also try :root in the css to define the colors at the start of the file then you can use var() to call the color.
Marked as helpful - @ViniciusMassari@suhaib52
Your code is looking clean and easy to read. Try to use :root to define the colors once at the start of the css sheet and then just call them by using color: var(). It is also nice if you define the font in the style sheet rather than in the html file. For image it is also good practice to add the width and height attribute in the image tag.
Marked as helpful - @lovishduggal@suhaib52
Hello Lovish,
Your solution is very clean. I like your approach. It would be better if you add external style sheet. That would make your code more readable. Best of luck for next time!
Marked as helpful