Skip to content
  • Unlock Pro
  • Log in with GitHub
Profile
OverviewSolutions
10
Comments
10
suhaib52
@suhaib52

All comments

  • BLESSING DAWODU•10
    @DammyD
    Submitted over 2 years ago

    3 column preview card component with html and responsive css

    #accessibility#contentful#bem
    2
    suhaib52•280
    @suhaib52
    Posted over 2 years ago

    You did it in a very good manner. Your code is well structured and readable.

    It would be nice if you start using semantic html tags, these tags would reduce the accessibility issues.

    You can also use :root to define the colors and then call them by using var() in your stylesheet. When you use the colors as a variable than your css code will look more precise.

    Marked as helpful
  • Hugo Almeida•730
    @almeida883
    Submitted over 2 years ago

    Resposive with Flexbox

    2
    suhaib52•280
    @suhaib52
    Posted over 2 years ago

    You did it in a very good manner. Your code is well structured and readable.

    It would be nice if you start using semantic html tags, these tags would reduce the accessibility issues.

    You can also use :root to define the colors and then call them by using var() in your stylesheet.

    I do not understand why you create separate style sheet for mobile and desktop.

    Marked as helpful
  • iris_rose 23•70
    @sawsan-code
    Submitted over 2 years ago

    Product preview card component with flex-box

    2
    suhaib52•280
    @suhaib52
    Posted over 2 years ago

    Good job! Your code is well structured and readable. For html, try to use semantic html tags. Semantic html tag would help to improve the accessiblity.

    Marked as helpful
  • Frunză Ștefan•90
    @stefan123283
    Submitted over 2 years ago

    pricing-card-frontend-mentor-challenge

    1
    suhaib52•280
    @suhaib52
    Posted over 2 years ago

    It would be better if you use the semantic html tags because these tags would reduce the accessibility issues.

    You can also define the body in more details to make it more better such as; body { width: 100%; height: 100vh; display: flex; align-items: center; justify-content: center; font-family: 'Karla', sans-serif; background-color: var(--grayishBlue); font-size: 16px; }

    Also use the margin 0 auto on the card id so it should be in the center of the page.

    It would be nice if you use classes more as compared to the ids.

    Marked as helpful
  • kathrryn1•40
    @kathrryn1
    Submitted over 2 years ago

    Stats Preview Card Component Solution

    1
    suhaib52•280
    @suhaib52
    Posted over 2 years ago

    Your code is well structured and easily readable. Good job! You can define the colors by using :root at the start of the style sheet and then call them by using var().

    Marked as helpful
  • Myro Joy Lee•120
    @myrojoylee
    Submitted over 2 years ago

    Profile card using HTML and CSS

    1
    suhaib52•280
    @suhaib52
    Posted over 2 years ago

    I think you need to use the position relative and then use bottom property to move the profile picture.

  • Shraddha Vkarma•40
    @Shraddha-V22
    Submitted over 2 years ago

    Product preview card component using CSS flexbox

    2
    suhaib52•280
    @suhaib52
    Posted over 2 years ago

    Your code is looking clean. It would be great if you use classes as compared to the ids in the html, because use of classes considered best practice as compared to the ids.

    Marked as helpful
  • Ajogu Chinasa•20
    @ajchinasa
    Submitted over 2 years ago

    QR code desktop & mobile view using HTML & CSS.

    2
    suhaib52•280
    @suhaib52
    Posted over 2 years ago

    It would be great to use semantic tags than the div, because semantic tags improve the accessiblity.

    You can also try :root in the css to define the colors at the start of the file then you can use var() to call the color.

    Marked as helpful
  • Vinícius Massari•210
    @ViniciusMassari
    Submitted over 2 years ago

    QR code componente using flexbox

    1
    suhaib52•280
    @suhaib52
    Posted over 2 years ago

    Your code is looking clean and easy to read. Try to use :root to define the colors once at the start of the css sheet and then just call them by using color: var(). It is also nice if you define the font in the style sheet rather than in the html file. For image it is also good practice to add the width and height attribute in the image tag.

    Marked as helpful
  • Lovish Duggal•180
    @lovishduggal
    Submitted about 3 years ago

    Order-Summary-Component-main Build With : HTML5 & CSS

    3
    suhaib52•280
    @suhaib52
    Posted about 3 years ago

    Hello Lovish,

    Your solution is very clean. I like your approach. It would be better if you add external style sheet. That would make your code more readable. Best of luck for next time!

    Marked as helpful
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub