Skip to content
OverviewSolutions
4
Comments
4
sunnyegg
@sunnyegg

All comments

  • sunnyegg•80
    @sunnyegg

    Nice solution! I learned about clamp!

  • devindubin•60
    @devindubin
    What are you most proud of, and what would you do differently next time?

    I think I got the sizing done much better using measuring tools online.

    What challenges did you encounter, and how did you overcome them?

    Centering all items within the card and getting special spacing between some elements but not others. I was able to do this by using flexbox for the card element but applying data attributes to elements that had unique aspects.

    I also used custom properties to set up reusable variables.

    What specific areas of your project would you like help with?

    Be critical! What's a better way I could do something? What did I miss?

    Social Links Profile

    2
    sunnyegg•80
    @sunnyegg

    Hi! First of all, good job on completing the challenge! There are some things that I noticed when I looked at your site and the code.

    1. The website is fine when I open it on Desktop Screen, but when I downsize the screen to Mobile, the card got really tiny. I think you can just remove the width and the height on your card class. Or you can set the maximum of the card's size using max-width and max-height attributes.

    2. Remove unused codes in your CSS file.

    Cheers!

    Marked as helpful
  • sunnyegg•80
    @sunnyegg
    • I learned that to center the card horizontally and vertically, we can just make the container flex and justify & align center. Thank you.
    • You can use css variable so you can reuse some of your code. Such as in color. CSS Variable
  • sunnyegg•80
    @sunnyegg

    Nice layout and looks like the design on figma. To make it reusable, you could make a class card.

    Marked as helpful