Achmad Riyadi• 70
@AchmadRiyadi
Submitted
This is my first challenge, any feedback is welcome.
Syazwan Fitri
@syzwnftr
All comments
- Syazwan Fitri• 400
@syzwnftr
Posted
Hi there! Good job on this challenge. I see you have some accessibility issues, so this is my suggestion:
- You might want to change
<div class = "container">to<main class = "container">since page should have one<main>tag - Change
<h2>to<h1> - Wrap
<div class="attribution">with<footer>
Hope these would fix the issues. Have a good day!
Marked as helpful
0 - You might want to change
- Sai Thi Han• 20
@SaiThihan
Submitted
Any feedback or suggestions? I'll be happy to improve myself with your help
Syazwan Fitri• 400@syzwnftr
Posted
Hi there! Good job on this challenge. I see you have some accessibility issues, so this is my suggestion:
- Change
<section>to<main> - Change
<h2>to<h1>
These should fix the issues. Have a good day!
0 - Change
- Steven Clark• 10
@phtevenclarkos
Submitted
Would love some feedback on my code, cheers!
Syazwan Fitri• 400@syzwnftr
Posted
Hi Steven, as a first project I think this is good. But I noticed that it isn't responsive so maybe you can set max-width instead of width for main-box. Make sure to avoid using px because it is an absolute unit. For the accessibility issue, you can get rid of it by changing h2 to h1. I hope this will help.
Marked as helpful
1 - SHAHAB MALIK• 345
@Shahab-Malikk
Submitted
Any kind of feedback will be appreciated.
Syazwan Fitri• 400@syzwnftr
Posted
Hi, I think this is good. For the accessibility issues, you can get rid of that by changing div tag that wrapped all the contents into main tag. That should fix the problem.
0 - Fide• 20
@fidelp27
Submitted
I need a feedback
Syazwan Fitri• 400@syzwnftr
Posted
Hey, this is good for your first project. I noticed there is an accessibility issues in the solution, which I also had it when I first submit mine. Here's what I'd suggest to get rid of these:
- Change the <div> right after <body> to <main>
- Change <h2> tag to <h1> tag
- Change the <div> before </body> to <section> or you can just put the <div> inside <main> tag.
I hope this will help.
Marked as helpful
0
