Chaman• 120
@chaman-rawat
Submitted
I really enjoyed doing this challenge. Any suggestions or improvements are appreciated.
Mzer Emmanuel Terdoo
@terdoo-mzer
All comments
- Mzer Emmanuel Terdoo• 145
@terdoo-mzer
Posted
Hey buddy! Cool project! You didn't implement the local storage feature... Hope that wasn't too too much of an issue for you? But overall, your design is cool!
1 @codermuyi
Submitted
This is my first project using APIs in React. I will welcome any feedback from the community.
Mzer Emmanuel Terdoo• 145@terdoo-mzer
Posted
I love your solution man!!! Way to go!
1- Samir• 420
@ryuzaki979
Submitted
Thanks for viewing this project. If you completed this project then provide your repository link.
It was fun to build this project. /Topics/ Changing multiple data || Work with JSON file
Mzer Emmanuel Terdoo• 145@terdoo-mzer
Posted
Hi, This is a nice project. Can you please verify that your code for this challenge is visible on github? The link you supplied above gives a 404 response.
0 - Eles• 1,300
@eleswastaken
Submitted
Mzer Emmanuel Terdoo• 145@terdoo-mzer
Posted
Hello there! Well done for your efforts. But a few touches here and there would be fine;
-
Maybe you can try resizing your images so that they don't occupy the whole space in the container. (I noticed this on large screens. Your images are nice on small screens however). Try using this; img { width: 100%; max-width:600px /* You can manipulate this and try to see how they respond*/ } Note: "img" is a selector. You could use whatever selector you have for you images. width: 100% ensures the image always takes 100% of whatever space allotted to it on whatever screen size. So the image scales nicely down and up when you resize the browser.
-
I do not know what screen you might be using though. But I see a horizontal scrollbar at the bottom of my screen. To deal with this, you should add this to your css; body {overflow-x:hidden}. I am sure this will deal with the overflow.
-
Your footer logo isn't visible. It is actually an svg. What I would do is, duplicate the image and rename it. Click on the svg to open in your code editor and look for "fill" property for each of the svg and change to desired color.
Happy coding!
Marked as helpful
2 -
- Tianao Meng• 280
@tianao-meng
Submitted
Mzer Emmanuel Terdoo• 145@terdoo-mzer
Posted
Hi there! Nice solution! However, You may want to check the social media icons, and contact images (telephone, mail and location) at the footer as they currently are not loading. I have tried to refresh my browser to see but it doesn't work. Keep coding!
0 - Khushmanpreet Singh• 20
@KhushmanPreet
Submitted
Any review or help would be appreciated I think I made it quite good isnt it ?
Mzer Emmanuel Terdoo• 145@terdoo-mzer
Posted
Well done! You might want to add a little a little more "top" property or "margin-top" to the image so it's perfectly centered between the top and bottom section of the card. Cheers! Keep coding!!!!!
0 - Gustavo Monteiro• 40
@gustavoA7X612BR
Submitted
Any sugestions?
Mzer Emmanuel Terdoo• 145@terdoo-mzer
Posted
Nice card! Keep coding!!!!
0 - Lalit Rathore• 25
@lalitwizz21
Submitted
I think there's some problem with github pages because when I'm running my code in browser with editor its working fine, but on github page the buttons move towards bottom.
Mzer Emmanuel Terdoo• 145@terdoo-mzer
Posted
Hi buddy! Well done for the efforts you have put in there. I see you added a lot of twists to the challenge. Are those intentional? Maybe to just try out your creativity or something??? That the case then welldone. Although it's best to ensure your solution is as exactly as the challenge. If you need any help to vamp your solution, I am pleased to offer you some.
Cheers buddy!
1 - Jennifer• 220
@Jennifer1919
Submitted
Mzer Emmanuel Terdoo• 145@terdoo-mzer
Posted
Hi @Jennifer1919 well done for the work! Maybe you could take a look at my repository to see how to add the Javascript validation on the form. I am pleased to help should you have any questions. My repo url: https://github.com/terdoo-mzer/form-with-html-css-javascript-and-regex/blob/main/scripts/script.js
0 - Sheri Richardson• 395
@shericodes
Submitted
Designo using Gatsby.js, Sanity.io as CMS, and styled-components
#gatsby#react#styled-components#sanityMzer Emmanuel Terdoo• 145@terdoo-mzer
Posted
Hi this is nicely done.
0 - Joseph Low• 30
@jolow99
Submitted
Test
Mzer Emmanuel Terdoo• 145@terdoo-mzer
Posted
Hi! I am wondering if you submitted the right project. Your solution doesn't match the design. Maybe you could recheck. Do you need any assistance?
1 Any feedback always welcome. Second project completed. I think it went way better then the Stats preview card component. One thing I wish I would of done mobile first then worked my way up. Like I did for Stats preview card. Also I forgot that there was a different asset for the hero picture for tablets and phone sizes. But none the less I'm really excited for how I got it to turn out.
Mzer Emmanuel Terdoo• 145@terdoo-mzer
Posted
Howdy! Great job you've done here!
0- zahrabku• 40
@zahrabku
Submitted
it was my first attempt to code a design from scratch. after 3 attempts I finally did it.
Mzer Emmanuel Terdoo• 145@terdoo-mzer
Posted
Great efforts you have put in there! I plan to put in mine soon enough.
0
