Skip to content
OverviewSolutions
11
Comments
12
P
M Rafay
@the-Exalter

All comments

  • Sameer Mehta•170
    @Sameer1003
    What specific areas of your project would you like help with?

    I would really like help with the following problem that I am unable to resolve in my Javascript code.

    Problem:

    In my project, I have 2 HTML files, index.html and sign-up-success.html. In index.html, I have a form which on submit takes me to sign-up-success.html page and in sign-up-success.html page I have a dismiss button which I want that on click should redirect again to index.html page. The problem is, that I am using a single Javascript file to handle these two HTML files. But, since initially index.html page will be open, the dismiss button will be undefined and hence the variable assigned to it will give null value. How can i Handle this?

    For reference, check line number 2 and line number 54 to 60 in script.js file. These lines are currently commented out.

    Any kind of suggestion with any part of my code is appreciated. Please try to be specific with which part improvement is possible.

    Completed the Newsletter Sign Up page

    1
    P
    M Rafay•140
    @the-Exalter

    had same problem

  • P
    M Rafay•140
    @the-Exalter

    Impressive!!!

  • P
    M Rafay•140
    @the-Exalter

    Hi, I can't thank you enough for the feedback as it was my last challenge of HTML and CSS path, I really needed all the things that you mentioned and surely I will look into everything as I am planning to do all those challenges again to learn from the mistakes and apply the things that I have learned from feedback like yours and others. And hope to see your feedback on that too. Thank you really much👍😀

  • Adam•340
    @nadam-design
    What are you most proud of, and what would you do differently next time?

    I’m most satisfied with the solution for the images: I separated them so they can be animated individually, and thanks to flex and grid, their placement is easy to manage.

    What challenges did you encounter, and how did you overcome them?

    The hardest task was implementing the spacing system. I think I overcomplicated it.

    What specific areas of your project would you like help with?

    The Spacing System: is it a good approach to define individual spacing values as variables in :root and then adjust them with media queries? Or is clamp() more effective? I feel like both are complicated to understand and maintain.

    Meet landing page using CSS Grid and Flexbox

    1
    P
    M Rafay•140
    @the-Exalter

    Hi, your projects looks great and I have just completed mine, seeing your project it is so so good, can you please review my project too and give some feedback, it would mean a lot. Thank you.

  • P
    MartynaGit•170
    @MartynaGit
    What specific areas of your project would you like help with?

    I am available that I managed to use the grid. I don't know how to determine the maximum size of a given card in the grid so that it does not extend to 1 fr

    my first project with grid

    1
    P
    M Rafay•140
    @the-Exalter

    Hey, congrats on completing this challenge, it was a tough one for me, so I can't give much feedback but I think the height should be somewhat shorter.

    Thank you

  • P
    M Rafay•140
    @the-Exalter

    Hi, congrats on completing this challenge!

    Your website looks very good and very close to the original desgin, I want to thank you for the inspriration I will surely try again.

    Thank you

  • P
    M Rafay•140
    @the-Exalter

    Hey, congrats on completing your challenge!

    There are few things that I think would need to be looked at:

    1.Size of product image and text side should be same. 2.Font families are not the right ones. 3.You did'nt give the correct link to your code.

    Marked as helpful
  • P
    M Rafay•140
    @the-Exalter

    Hey, congrats on completing your challenge!

    There are few things that I think would need to be looked at:

    1.Size of product image and text side should be same. 2.Font families are not the right ones. 3.You did'nt give the correct link to your code.

  • P
    M Rafay•140
    @the-Exalter

    Hi, congrats on completing this challenge!

    I think there are some changes you can do to make your better.

    1.Adding padding to the menu would help a lot. 2.Making the height of menu "max-content". 3.Add some spacing between each section and paragraphs. 4.Some changes in Font Family.

  • manishkumar12i•130
    @manishkumar12i
    What are you most proud of, and what would you do differently next time?

    This webpage give me some confidenece to make it responsive and next time i will make new challenge more reponsive.

    What challenges did you encounter, and how did you overcome them?

    I face so many diffulties and able to solve that issues

    responsive social media links

    #pure-css
    1
    P
    M Rafay•140
    @the-Exalter

    Hi, congrats on completing on your project!

    Your project is very inspiring but I think the spacing needs to be checked.

  • P
    M Rafay•140
    @the-Exalter

    Hi, congrats on completing the project!

    There are few things that I think you forgot to do like, 1.Curved borders of illustration 2.Box shadow could be more wide 3."Learning", published date and description, their font-size and size require some adjustment. 4.Author's name and picture should be in the box.

  • P
    M Rafay•140
    @the-Exalter

    Congratulations on completing the project!

    Your work is amazing and I have learned much from it.

    Thank you.