@Tasin269
Daniel king
@thedanielkingAll comments
- @thedanielking
Hi, I think you submitted the wrong code link for the project. The design is meant to be a result summary component and not a recipe page.
- P@To-be-Sun@thedanielking
hi man, good work there. A few takeaway here though:
- Its obvious home tab is visible on how it doesn't flex to be side by side.
- I think creating an html page for each since tab isnt ideal frs. Try looping through a data.json file to put those section when needed in the code.
- @snigdha-sukun@thedanielking
Hi there, great work. I love the movement you did with the features section. I just think there is alot of css property involved in the javascript and it looks a little confusing. For readability, you can write a few comment lines to make it easier to learn from you.
- @hansaldev@thedanielking
Nice Javascript. I loved the logic behind it making it seamless. I think you forget to put a hover effect on your navbar and also, the menu button should be on the left so that it can be directly under the close button for better user experience. Great work! Keep coding!
- @cas1092@thedanielking
Hi there, nice attempt and I love the way you made the responsiveness on the work grid. A few takeaways I'm sure you are aware of.
- The nav list are not styled properly. You can style the over effect using the ::after element in css.
- Also, the footer should be justified space between to give space and also the socials should be flex-end to start from the end. Great work by the way and keep on coding. You'll get there!
- @a5420bc@thedanielking
Good work man. I think you should try external styling next time which gives a bit more organization for code and makes it easier for other developers to go through your code.
- P@marcello88c@thedanielking
Great code and I love the transitions.
- @gowthamjk08@thedanielking
I love how your JavaScript code is so concise honestly man. Well, i think you already know what's up with your code but for clarity sake ill just state the obvious. In simple terms the styling, i am referring to the coloring, is not the same as the design. Im sure you can figure that out easily.
Marked as helpful - @hyperavtr@thedanielking
wow. Love your javascript code.
- P@jdillard2532@thedanielking
Hi there, nice work you did there. I love the way your javascript looks clean. Keep it up man.
- @RohloffmeisterWhat are you most proud of, and what would you do differently next time?
That i made it in a short amount of time. Better naming of classes and ids.
@thedanielkingHi there, good work man. A few words on your work if you dont mind. Try working more on learning how to center your container to the middle. There are several ways you can but setting "Height= 100%" makes the chrome scrollable and doesnt look good in a big screen size. Other ways i center mine is using: "position: absolute; top: 50%; left: 50%; transform: translate(-50%, -50%); margin-right: -50%; " there are other ways you can. Your colors too can be improved on by matching the colors and padding used in the submit button too.
- @calvinvinWhat are you most proud of, and what would you do differently next time?
More practice on html form elements, css container queries, and javascript.
@thedanielkingWow, i love how your code is so clean and the way your javascript is refractored. Looking to learn that from your code.
- @AbdelmonemMareiWhat specific areas of your project would you like help with?
I appreciate any feedback or suggestions helping me to improve my next challenge. Feel free to leave a comment.
@thedanielkingNice work.
- P@pelzmagicWhat are you most proud of, and what would you do differently next time?
I had a problem with writing my media queris for the mobile design, but, i am proud that i was able to overcome this challenge eventually. I intend to be faster with future projects next time.
What challenges did you encounter, and how did you overcome them?I had a problem with writing my media queries, but i was able to overcome this challenge with adequate research on css media queries.
@thedanielkingHey, great job. Well, everybody has their own ways but writing less code is more advisable especially for the Regular expressions test. I suggest you use /.+@.+..+/ but as I said, there are other better ways.
Also, for the @media query, I think it's more easier when you plan how to write the code for the large before the smaller screen. And using responsive units like em and rem could soften the load.
- @Raptor0x1What specific areas of your project would you like help with?
- I need help with the image in the component. You can compare the image in my attempt to the solution. The image is somehow cropped and there's some space left in the desktop view at the bottom. It's most likely due to image.
- Any suggestions would be appreciated on making the javascript code more efficient?
@thedanielkingNice work man. I had the same issue concerning the image since from the solution it appears to be cropped. I like you JavaScript as well. Could you by chance in a line explain the condition for your JavaScript ?
- @JoelJohs@thedanielking
I cant see the task solution
- @BANKOLEDOWhat are you most proud of, and what would you do differently next time?
I was able to utilize CSS Grid Finally and I am proud of the results
What challenges did you encounter, and how did you overcome them?When i tried to make the webpage responisive, i had issues with the row and column gap, i was able to overcome it by checking out about grid in MDN.
What specific areas of your project would you like help with?I am open to suggestions
- @ahmedmohamedag@thedanielking
Good job there, I just think you could work a little on your colors and the font weight especially in the price section.
